Opened 6 months ago

Last modified 5 months ago

#33998 needs_review defect

stop using XUL <grid> soon

Reported by: mcs Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ReleaseTrainMigration, ff78-esr, TorBrowserTeam202006R
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Child Tickets

Change History (5)

comment:1 Changed 5 months ago by mcs

Keywords: ff78-esr added

comment:3 Changed 5 months ago by mcs

Cc: tbb-team added
Keywords: TorBrowserTeam202006 added
Owner: changed from tbb-team to mcs
Status: newassigned

comment:4 Changed 5 months ago by mcs

Keywords: TorBrowserTeam202006R added; TorBrowserTeam202006 removed
Status: assignedneeds_review

Here is tor-browser patch (#31286 fixup based on acat's 33533+5 branch):
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug33998-01&id=31514225ccfe42137cc9b7e74c22a426b853f847&context=3&ignorews=0&dt=0

Here is a patch for Tor Launcher:
https://gitweb.torproject.org/user/brade/tor-launcher.git/commit/?h=bug33998-01&id=1d25ec79dcc1dcf84893a8a3237e865c1cdd47d2

Note that -w makes the diffs a lot smaller :)
We switched to CSS grid and then had to make a few small changes to get the layout to match the current (XUL <grid>) one.

comment:5 Changed 5 months ago by acat

It seems <grid> was not yet removed in 78, but it's good to stop using it in any case.

Looks good, just one small nit: with the changes, the torPreferences-advanced-textboxAllowedPorts input does not fully expand until the end of the column as before, maybe now it needs -moz-box-flex: 1; for that?

Note: See TracTickets for help on using tickets.