Bump node version to v10.21.0

Update our node version to what is used in mozilla-central.

Trac:
Parent Ticket: #33184 (moved)

added GeorgKoppen202006 TorBrowserTeam202006 component::applications/tor browser gitlab-tb-tor-browser-build owner::gk parent::33184 points::0.1 priority::high reviewer::ahf severity::normal sponsor::58-must status::needs-revision tbb-mobile tbb-rbm type::defect labels

End-of-life: April 2021 Critical bug fixes and security updates: https://nodejs.org/download/release/latest-dubnium/

Trac:
Owner: tbb-team to gk
Cc: sysrqb, boklm, acat to tbb-team
Parent: #33626 (moved) to #33184 (moved)
Status: new to assigned
Keywords: TorBrowserTeam202004 deleted, GeorgKoppen202005, TorBrowserTeam202005 added

Moving tickets to high prio.

Trac:
Priority: Medium to High

This is ready for review on my branch fenix_toolchain (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=fenix_toolchain&id=e2f68244a5faca57c12510f47a1252c9a5584a50).

Trac:
Keywords: TorBrowserTeam202005 deleted, TorBrowserTeam202005R added
Status: assigned to needs_review

Looks good to me. Would it be worth deviating from mozilla and use the latest v10 version instead? (currently v10.20.1)

Replying to acat:

Looks good to me. Would it be worth deviating from mozilla and use the latest v10 version instead? (currently v10.20.1)

I am not convinced it would be. First, Mozilla might have a reason to stick to this particular version (we have seen [comment:7:ticket:30321 weird bugs in node before] which we'd maybe need to work around otherwise). Second, I plan to have a script to alert us once we deviate from Mozilla's toolchain requirements so we can adapt. I believe the more we differ from what Mozilla is using the harder it will be to keep track. Third, it's a compile-time dependency, no runtime dependency. Thus, updating to the latest and greatest version security-wise is not as urgent IMO.

sponsor58-must

Trac:
Sponsor: N/A to Sponsor58-must

Trac:
Reviewer: N/A to ahf

This one was reviewed as part of the review of #33973 (moved).

Trac:
Status: needs_review to merge_ready

Moving review tickets.

Trac:
Keywords: TorBrowserTeam202005R deleted, TorBrowserTeam202006R added

It's v10.21 now (beta and central).

Trac:
Status: merge_ready to needs_revision

Trac:
Keywords: GeorgKoppen202005, TorBrowserTeam202006R deleted, TorBrowserTeam202006, GeorgKoppen202006 added
Summary: Bump node version to v10.19 to Bump node version to v10.21.0
Points: N/A to 0.1

Add magic gitlab keyword.

Trac:
Keywords: N/A deleted, gitlab-tb-tor-browser-build added

changed time estimate to 48m

mentioned in issue #33184 (moved)

moved to tpo/applications/tor-browser-build#34013 (closed)