Opened 7 months ago

Last modified 6 months ago

#34013 needs_revision defect

Bump node version to v10.21.0

Reported by: gk Owned by: gk
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, tbb-rbm, GeorgKoppen202006, TorBrowserTeam202006, gitlab-tb-tor-browser-build
Cc: tbb-team Actual Points:
Parent ID: #33184 Points: 0.1
Reviewer: ahf Sponsor: Sponsor58-must

Description

Update our node version to what is used in mozilla-central.

Child Tickets

Change History (13)

comment:1 Changed 7 months ago by cypherpunks

End-of-life: April 2021
Critical bug fixes and security updates: https://nodejs.org/download/release/latest-dubnium/

comment:2 Changed 7 months ago by gk

Cc: tbb-team added; sysrqb boklm acat removed
Keywords: TorBrowserTeam202005 GeorgKoppen202005 added; TorBrowserTeam202004 removed
Owner: changed from tbb-team to gk
Parent ID: #33626#33184
Status: newassigned

comment:3 Changed 7 months ago by gk

Priority: MediumHigh

Moving tickets to high prio.

comment:4 Changed 7 months ago by gk

Keywords: TorBrowserTeam202005R added; TorBrowserTeam202005 removed
Status: assignedneeds_review

comment:5 Changed 7 months ago by acat

Looks good to me. Would it be worth deviating from mozilla and use the latest v10 version instead? (currently v10.20.1)

comment:6 in reply to:  5 Changed 7 months ago by gk

Replying to acat:

Looks good to me. Would it be worth deviating from mozilla and use the latest v10 version instead? (currently v10.20.1)

I am not convinced it would be. First, Mozilla might have a reason to stick to this particular version (we have seen weird bugs in node before which we'd maybe need to work around otherwise). Second, I plan to have a script to alert us once we deviate from Mozilla's toolchain requirements so we can adapt. I believe the more we differ from what Mozilla is using the harder it will be to keep track. Third, it's a compile-time dependency, no runtime dependency. Thus, updating to the latest and greatest version security-wise is not as urgent IMO.

comment:7 Changed 7 months ago by gk

Sponsor: Sponsor58-must

sponsor58-must

comment:8 Changed 7 months ago by ahf

Reviewer: ahf

comment:9 Changed 7 months ago by ahf

Status: needs_reviewmerge_ready

This one was reviewed as part of the review of #33973.

comment:10 Changed 6 months ago by gk

Keywords: TorBrowserTeam202006R added; TorBrowserTeam202005R removed

Moving review tickets.

comment:11 Changed 6 months ago by acat

Status: merge_readyneeds_revision

It's v10.21 now (beta and central).

comment:12 Changed 6 months ago by gk

Keywords: GeorgKoppen202006 TorBrowserTeam202006 added; GeorgKoppen202005 TorBrowserTeam202006R removed
Points: 0.1
Summary: Bump node version to v10.19Bump node version to v10.21.0

comment:13 Changed 6 months ago by gk

Keywords: gitlab-tb-tor-browser-build added

Add magic gitlab keyword.

Note: See TracTickets for help on using tickets.