Opened 6 months ago

Last modified 5 months ago

#34022 new task

Rename the testbuild/torbrowser-testbuild targets

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam202004, tbb-maint
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

For release, alpha and nightly we use the same target name in projects/release/config and other components.

For testbuild however, we use the testbuild target in projects/release/config, which is using the torbrowser-testbuild target (defined in rbm.conf) for building other components, which can be confusing. There is also a testbuild target in rbm.conf, which is used by torbrowser-testbuild.

I think we could fix that by renaming the torbrowser-testbuild target we have in rbm.conf to testbuild, and the current testbuild target to testbuild-common.

This will however require that people who use a custom rbm.local.conf update it.

Child Tickets

Change History (2)

comment:1 Changed 6 months ago by boklm

An other possible change, related to this, is having separate makefile rules and rbm targets for alpha and nightly builds.

Currently, selecting whether you want to do a nightly or alpha testbuild is hidden into a configuration file, but it might be better to select explicitly for each testbuild whether you want it to be alpha or nightly, for example with make testbuild-alpha or make testbuild-nightly.

comment:2 Changed 5 months ago by gk

Keywords: tbb-maint added
Note: See TracTickets for help on using tickets.