Opened 8 years ago

Closed 8 years ago

Last modified 6 years ago

#3403 closed defect (fixed)

Double mark-for-close when connection_ap_handshake_rewrite_and_attach rejects a stream

Reported by: rransom Owned by: nickm
Priority: Low Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: bufferevents tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When I attempted to connect to http://duskgytldkxiuqc$.onion/ (using usewithtor w3m; I don't know whether Firefox would try to connect to that hostname) using my feature2553-v2 branch ( git://git.torproject.org/rransom/tor.git feature2553-v2 ) (compiled with --enable-bufferevents), Tor produced the following warning message:

Jun 15 02:41:53.000 [warn] Invalid onion hostname [scrubbed]; rejecting
Jun 15 02:41:53.000 [warn] Bug: Duplicate call to connection_mark_for_close at connection.c:2956 (first at connection_edge.c:1702)

connection.c:2956 is in connection_handle_read_cb; connection_edge.c:1702 is in connection_ap_handshake_rewrite_and_attach.

Child Tickets

Change History (3)

comment:1 Changed 8 years ago by nickm

Resolution: fixed
Status: newclosed

fixed in master; thanks!

comment:2 Changed 6 years ago by nickm

Keywords: tor-client added

comment:3 Changed 6 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.