Opened 6 months ago

Last modified 5 months ago

#34065 needs_review enhancement

Make routerset_contains_router() support IPv6

Reported by: teor Owned by: neel
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: ipv6, prop311, 044-can
Cc: nickm, neel Actual Points:
Parent ID: #33221 Points: 0.5
Reviewer: Sponsor: Sponsor55-can

Description

In router_should_check_reachability(), we test to see if the current relay is in ExcludeNodes.

But ExcludeNodes doesn't support IPv6, so if a user excludes our IPv6 address, we'll just ignore that setting.

This is not a required task.

But we should probably be explicit about ignoring IPv6 in the man page.

Child Tickets

Change History (6)

comment:1 Changed 5 months ago by nickm

Keywords: 044-can added; 044-should removed

comment:2 Changed 5 months ago by neel

Owner: set to neel
Status: newassigned

comment:3 Changed 5 months ago by neel

Cc: neel added

comment:4 Changed 5 months ago by neel

Type: defectenhancement

PR: https://github.com/torproject/tor/pull/1931

I think this is an "enhancement", but if it is a "defect" change it back.

comment:5 Changed 5 months ago by neel

Status: assignedneeds_revision

comment:6 Changed 5 months ago by neel

Status: needs_revisionneeds_review
Note: See TracTickets for help on using tickets.