Opened 6 months ago

Last modified 5 months ago

#34068 new defect

Decide how to handle control port events for IPv6 reachability self-tests

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: ipv6, prop311, control-spec, 044-deferred
Cc: nickm Actual Points:
Parent ID: #33221 Points: 1
Reviewer: Sponsor: Sponsor55-must

Description

The control spec has two reachability self-test events.

Here is how they are specified:

     CHECKING_REACHABILITY
     "ORADDRESS=IP:port"
     "DIRADDRESS=IP:port"
       We're going to start testing the reachability of our external OR port
       or directory port.

     REACHABILITY_SUCCEEDED
     "ORADDRESS=IP:port"
     "DIRADDRESS=IP:port"
       We successfully verified the reachability of our external OR port or
       directory port (depending on which of ORADDRESS or DIRADDRESS is
       given.)

And here is what tor actually sends:

CHECKING_REACHABILITY ORADDRESS=IPv4:port
CHECKING_REACHABILITY DIRADDRESS=IPv4:port
REACHABILITY_SUCCEEDED ORADDRESS=IPv4:port
REACHABILITY_SUCCEEDED DIRADDRESS=IPv4:port

When we add IPv6 reachability events, we could break some (buggy) control parsers with:

CHECKING_REACHABILITY ORADDRESS=[IPv6]:port
REACHABILITY_SUCCEEDED ORADDRESS=[IPv6]:port

How should we handle this change?

Child Tickets

Change History (4)

comment:1 Changed 6 months ago by teor

Parent ID: #33222#33221

comment:2 Changed 6 months ago by nickm

How should we handle this change?

If we're feeling cautious, we could add a new event type. Alternatively, we could do a small survey of the major controllers and make sure they support IPv6 in this context.

Since this is a relay-only event, I think we'll probably be okay: most of the fragile controller work that I'm aware of has been client-only.

comment:3 Changed 6 months ago by teor

I just checked Stem, it doesn't seem to do any special parsing of these events. The event names only appear in the tests.

comment:4 Changed 5 months ago by nickm

Keywords: 044-deferred added
Milestone: Tor: 0.4.4.x-finalTor: unspecified

Bulk-remove tickets from 0.4.4. Add the 044-deferred label to them.

Note: See TracTickets for help on using tickets.