Opened 4 weeks ago

Closed 3 weeks ago

#34077 closed defect (fixed)

Fix compilation with GCC 10

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: 041-backport, 042-backport, 043-backport Actual Points:
Parent ID: Points: .1
Reviewer: teor Sponsor:

Description

Fedora 32 just came out, and it has GCC 10. (Wow, GCC 10!) We run into warnings there; let's fix them.

Child Tickets

Change History (4)

comment:1 Changed 4 weeks ago by nickm

Points: .1
Status: assignedneeds_review

There are only two actual warnings here: one introduced in 0.4.0, and one introduced in 0.4.3.

0.4.1: bug34077_041; PR at https://github.com/torproject/tor/pull/1875
0.4.2: bug34077_042; PR at https://github.com/torproject/tor/pull/1877
0.4.3: bug34077_043; PR at https://github.com/torproject/tor/pull/1878
0.4.4: bug34077_044; PR at https://github.com/torproject/tor/pull/1879

comment:2 Changed 4 weeks ago by teor

Reviewer: teor
Status: needs_reviewmerge_ready

Both of these look fine.

I'll let you decide how you want to backport.

comment:3 Changed 3 weeks ago by nickm

Merged to all affected branches; I rely on being able to build without warnings. :)

comment:4 Changed 3 weeks ago by nickm

Milestone: Tor: 0.4.4.x-finalTor: 0.4.1.x-final
Resolution: fixed
Status: merge_readyclosed
Note: See TracTickets for help on using tickets.