Opened 7 years ago

Closed 7 years ago

#3409 closed enhancement (fixed)

TorCtl connect method inflexible

Reported by: atagar Owned by:
Priority: Medium Milestone:
Component: Torctl Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The connect method is a nice helper for cli initiation, but lacks sufficient call visibility to help in more general use cases. In particular it...

  • sends feedback to stdout
  • prompts for the controller password on stdin
  • suppresses exceptions

To get around this I'm adding a more generic 'connectionComp' that does the icky bits of the connection negotiation I was trying to hide while still giving the caller what it needs to handle the connection process however it'd like.

Tested by exercising the connect functionality with cookies, password, and connection components to handle my TBB cookie auth renegotiation fix.

Child Tickets

Change History (4)

comment:1 Changed 7 years ago by atagar

Status: newneeds_review

comment:2 Changed 7 years ago by atagar

Pushed a fix for this change (connection wasn't being closed after authentication failures):
https://gitweb.torproject.org/atagar/pytorctl.git/commit/40f7cbc50d460d8e3e11669827108bfb912ab3bf

comment:3 Changed 7 years ago by mikeperry

Note to self: This patch by itself looks good. But it is based on others I still need to review.

comment:4 Changed 7 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

Merged.

Note: See TracTickets for help on using tickets.