Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#34103 closed defect (fixed)

Stop rounding y axis labels with units

Reported by: karsten Owned by: karsten
Priority: Medium Milestone:
Component: Metrics/Website Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points: 0.3
Parent ID: Points:
Reviewer: Sponsor:

Description

The Time to download files over Tor graph now displays the following labels, all using seconds as units: 0, 0, 1, 2, 2, 2. Better labels would be 0.0, 0.5, 1.0, 1.5, 2.0, 2.5.

Similarly, the Advertised bandwidth distribution graph showing the median displays the following labels, all using Gbit/s: 0.00, 0.02, 0.05, 0.08. Better labels would be 0.000, 0.025, 0.050, 0.075.

The underlying issue, which we didn't fix in #33933 nor in #33066, is that we have to pick a number of digits for a graph which then needs to work for whichever scale is being displayed. In some cases this is difficult to do right (first graph above with measurements apparently getting faster over time), in other cases it's impossible (second graph above with 1st and 99th percentile having different orders of magnitude).

The fix is to stop using the unit_format function from the somewhat outdated scales package that we're using and instead write our own function for formatting labels with units.

I'm going to attach two example graphs where this went wrong plus a patch that I'll review more carefully tomorrow before I deploy it on the server.

Child Tickets

Attachments (3)

torperf-public-2020-02-03-2020-05-03-50kb.png (85.6 KB) - added by karsten 2 months ago.
advbwdist-perc-50-2015-01-19-2020-04-18.png (67.4 KB) - added by karsten 2 months ago.
task-34103-patch.txt (6.5 KB) - added by karsten 2 months ago.

Download all attachments as: .zip

Change History (6)

Changed 2 months ago by karsten

Changed 2 months ago by karsten

comment:1 Changed 2 months ago by karsten



Changed 2 months ago by karsten

Attachment: task-34103-patch.txt added

comment:2 Changed 2 months ago by karsten

Points: 0.3
Resolution: fixed
Status: assignedclosed

Patch still looks good. Pushed to master with some trivial documentation tweaks and deployed to the server. Closing.

comment:3 Changed 2 months ago by karsten

Actual Points: 0.3
Points: 0.3
Note: See TracTickets for help on using tickets.