Opened 5 months ago

Closed 5 months ago

#34133 closed enhancement (implemented)

Tor documentation missing sandbox and %include limitations

Reported by: Jigsaw52 Owned by:
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: seccomp sandbox documentation
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description

The tor manpage and documentation do not tell the user that is not possible to add new configuration files to %included directories in its config files when the seccomp sandbox is enabled.

Child Tickets

Change History (4)

comment:1 Changed 5 months ago by Jigsaw52

Status: newneeds_review

Added pull request to fix this issue: https://github.com/torproject/tor/pull/1885

comment:2 Changed 5 months ago by nickm

Milestone: Tor: 0.4.4.x-final
Reviewer: nickm
Status: needs_reviewneeds_revision

LGTM, but see this note about the version number in the changes file from #31430:

The fix looks fine, but is this really a "bugfix on 0.4.4.0-alpha"? That is, is 0.4.4.0-alpha really the first version that has this bug, or is the bug older than that?

We try to keep track of which version introduced the bug, so we know how far back we might need to backport each fix.

comment:3 Changed 5 months ago by Jigsaw52

Status: needs_revisionneeds_review

This bug exists since the %include feature (ticket #1922) was implemented, in 0.3.1.1-alpha.

I've updated the changes file.

comment:4 Changed 5 months ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Thank you; this looks good to me now. Merged to master!

Note: See TracTickets for help on using tickets.