Opened 2 months ago

Closed 2 months ago

#34145 closed defect (fixed)

Investigate fallout from transitioning to 77.0b1

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, ReleaseTrainMigration, TorBrowserTeam202005, GeorgKoppen202005
Cc: tbb-team Actual Points:
Parent ID: #33533 Points:
Reviewer: Sponsor:

Description (last modified by gk)

Compilation is busted with our patches based on 77.0b1. This is the bug to investigate this.

Child Tickets

Attachments (1)

0001-Bug-1636036-Always-generate-headers-from-IPDL.patch (749 bytes) - added by gk 2 months ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 2 months ago by gk

Compilation fails with

50:00.21 In file included from /var/tmp/build/geckoview-4ac6652a6a29/mobile/android/components/geckoview/GeckoViewExternalAppService.cpp:10:
50:00.21 /var/tmp/build/geckoview-4ac6652a6a29/obj-arm-linux-androideabi/dist/include/mozilla/dom/WindowGlobalParent.h:14:10: fatal error: 'mozilla/dom/ClientIPCTypes.h' file not found
50:00.21 #include "mozilla/dom/ClientIPCTypes.h"
50:00.21          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This is tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=1636036.

comment:2 Changed 2 months ago by gk

Linking libxul fails now with

50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libaom/cpu-features.o: multiple definition of 'android_getCpuCount'
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libvpx/cpu-features.o: previous definition here
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libaom/cpu-features.o: multiple definition of 'android_getCpuFamily'
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libvpx/cpu-features.o: previous definition here
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libaom/cpu-features.o: multiple definition of 'android_getCpuFeatures'
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libvpx/cpu-features.o: previous definition here
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libaom/cpu-features.o: multiple definition of 'android_getCpuIdArm'
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libvpx/cpu-features.o: previous definition here
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libaom/cpu-features.o: multiple definition of 'android_setCpu'
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libvpx/cpu-features.o: previous definition here
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libaom/cpu-features.o: multiple definition of 'android_setCpuArm'
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libvpx/cpu-features.o: previous definition here

comment:3 in reply to:  2 Changed 2 months ago by gk

Replying to gk:

Linking libxul fails now with

50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libaom/cpu-features.o: multiple definition of 'android_getCpuCount'
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libvpx/cpu-features.o: previous definition here
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libaom/cpu-features.o: multiple definition of 'android_getCpuFamily'
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libvpx/cpu-features.o: previous definition here
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libaom/cpu-features.o: multiple definition of 'android_getCpuFeatures'
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libvpx/cpu-features.o: previous definition here
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libaom/cpu-features.o: multiple definition of 'android_getCpuIdArm'
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libvpx/cpu-features.o: previous definition here
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libaom/cpu-features.o: multiple definition of 'android_setCpu'
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libvpx/cpu-features.o: previous definition here
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libaom/cpu-features.o: multiple definition of 'android_setCpuArm'
50:41.65 /var/tmp/dist/android-toolchain/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: /var/tmp/build/geckoview-2c5ac3b9c8c3/obj-arm-linux-androideabi/toolkit/library/build/../../../media/libvpx/cpu-features.o: previous definition here

That's actually #31915 as we forgot a patch when rebasing.

comment:4 Changed 2 months ago by gk

Description: modified (diff)
Summary: Fix fallout from transitioning to 77.0b1Investigate fallout from transitioning to 77.0b1

Attached a patch for fixing https://bugzilla.mozilla.org/show_bug.cgi?id=1636036 if we really need it to do it ourselves.

comment:5 Changed 2 months ago by gk

Resolution: fixed
Status: newclosed

Okay, those were all the issues we had it seems, closing.

Note: See TracTickets for help on using tickets.