Opened 8 weeks ago

Closed 4 weeks ago

#34164 closed defect (fixed)

Tor Launcher hangs with 33533+5 branch

Reported by: acat Owned by: brade
Priority: Medium Milestone:
Component: Applications/Tor Launcher Version:
Severity: Normal Keywords: ff78-esr, TorBrowserTeam202006R
Cc: mcs, tbb-team Actual Points:
Parent ID: Points:
Reviewer: acat Sponsor:

Description

mcs/brade pointed to me that there seems to be a Tor Launcher deadlock inside a call to writeBytes() for the control port connection, with the latest 33533+5 branch from #33533.

They tested a debug build in macOS, but it also happens to me with a testbuild-linux-x86_64 build.

Child Tickets

Change History (7)

comment:1 Changed 8 weeks ago by gk

Cc: mcs tbb-team added
Owner: changed from tbb-team to brade

Let's tentatively assign this to mcs/brade as they started to look into that and have the time for it.

comment:2 Changed 8 weeks ago by mcs

Keywords: TorBrowserTeam202005R added; TorBrowserTeam202005 removed
Status: assignedneeds_review

comment:3 Changed 7 weeks ago by acat

Works fine for me. I agree that the long-term solution should be to switch to non-blocking sockets, but I understand that would mean a much bigger change than this. So I think this is ok for now.

comment:4 Changed 7 weeks ago by acat

Status: needs_reviewmerge_ready

Ok to merge in a esr78 branch.

comment:5 Changed 7 weeks ago by acat

Reviewer: acat

comment:6 Changed 5 weeks ago by gk

Keywords: TorBrowserTeam202006R added; TorBrowserTeam202005R removed

Moving review tickets.

comment:7 Changed 4 weeks ago by gk

Resolution: fixed
Status: merge_readyclosed

Thanks everyone. This landed on master (commit 98f3df12d48daf277f2e3f056600c64294c628c1), closing.

Note: See TracTickets for help on using tickets.