Opened 7 months ago

Last modified 6 months ago

#34189 new defect

tbb-testsuite: fix the settings test for 78

Reported by: acat Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Quality Assurance and Testing Version:
Severity: Normal Keywords: tbb-testsuite, ReleaseTrainMigration, TorBrowserTeam202006R
Cc: tbb-team Actual Points:
Parent ID: #27105 Points:
Reviewer: Sponsor:

Description

We should fix the settings tests so that it passes with the preferences that we currently have.

Child Tickets

Change History (4)

comment:1 Changed 7 months ago by acat

Keywords: TorBrowserTeam202005R added; TorBrowserTeam202004 removed
Status: assignedneeds_review

Patch in https://gitlab.torproject.org/acat/tor-browser-bundle-testsuite/-/commits/34189 (65cae7af429d29b37196482ca6a464f538750b94). This passes for me, running it with ./tbb-testsuite --default-retry 1 --no-xdummy --xvfb --enable-tests settings /path/to/33533+5/build.tar.xz.

Changed prefs:

Removed in 27268:
-----------------

browser.download.manager.retention
browser.download.manager.scanWhenDone
browser.newtabpage.preload
browser.pocket.api
browser.pocket.site
browser.safebrowsing.enabled -> browser.safebrowsing.phishing.enabled
browser.search.countryCode
browser.zoom.siteSpecific
datareporting.healthreport.about.reportUrl
datareporting.healthreport.about.reportUrlUnified
datareporting.healthreport.service.enabled
device.sensors.enabled
devtools.appmanager.enabled: None != False
devtools.webide.autoinstallADBHelper -> devtools.webide.autoinstallADBExtension
devtools.webide.autoinstallFxdtAdapters
dom.enable_performance
dom.enable_user_timing
dom.event.highrestimestamp.enabled
dom.gamepad.enabled
dom.maxHardwareConcurrency
general.appname.override
general.appversion.override
general.buildID.override
general.oscpu.override
general.platform.override
general.productSub.override
general.useragent.vendor
general.useragent.vendorSub
intl.charset.default
media.audio_data.enabled
media.eme.apiVisible
media.gmp-eme-adobe.enabled
media.gmp-eme-adobe.visible (not removed there, but mentioned)
media.video_stats.enabled
media.webspeech.synth.enabled
network.jar.block-remote-files
plugin.expose_full_path
privacy.suppressModifierKeyEvents
privacy.use_utc_timezone
security.pki.sha1_enforcement_level -> 4
security.tls.unrestricted_rc4_fallback
ui.use_standins_for_native_colors

Other
-----

dom.indexedDB.enabled (removed in #23745)
browser.pocket.enabled -> extensions.pocket.enabled (#31602)
extensions.langpacks.signatures.required (reenabled in #31942)
extensions.legacy.exceptions (doesn't do anything)
extensions.enabledItems (doesn't do anything)
extensions.enabledAddons (doesn't do anything)
app.update.auto (set to False by marionette, we can maybe cover this with separate update tests in the future)

comment:2 Changed 6 months ago by gk

Keywords: TorBrowserTeam202006R added; TorBrowserTeam202005R removed

Moving review tickets.

comment:3 Changed 6 months ago by acat

Owner: changed from acat to tbb-team
Status: needs_reviewassigned

We can do the reviewing in #27105 directly, I guess.

comment:4 Changed 6 months ago by acat

Status: assignednew
Note: See TracTickets for help on using tickets.