Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#3419 closed defect (fixed)

Revert or repair bug2355 changes

Reported by: nickm Owned by:
Priority: Very High Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version: Tor: 0.2.2.28-beta
Severity: Keywords: tor-client
Cc: anonym@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Apparently the changed semantics for UseBridges in Tor 0.2.2.28-beta caused some problems for Vidalia. The default "UseBridges auto" threw some people into bridge mode who didn't expect to be in bridge mode, and the new behavior of "UseBridges 1" with no bridges set made people's tors stop working without a clear explanation of why. See bug #3354 for full details.

Counterproposals to reverting seem too complex to me. I've got a branch "bug 2355_revert" in my public repository to do the revert. I suggest applying it to 0.2.2.x and 0.2.3.x. Comments?

Child Tickets

Change History (7)

comment:1 Changed 8 years ago by nickm

Status: newneeds_review

comment:2 in reply to:  description Changed 8 years ago by arma

Replying to nickm:

Apparently the changed semantics for UseBridges in Tor 0.2.2.28-beta caused some problems for Vidalia. The default "UseBridges auto" threw some people into bridge mode who didn't expect to be in bridge mode

For posterity, the problems were actually caused for Tor; Vidalia isn't even in the picture for this first issue. People running Tor 0.2.2.27-beta with Bridge lines but no UseBridge line had a valid and reasonable configuration. That configuration running 0.2.2.28-beta has a new and surprising behavior.

comment:3 Changed 8 years ago by arma

Patch looks good to me. I'd suggest the changes text change from "we broke a number of Vidalia users" to "we changed behavior in a surprising way for users who had bridges listed in their torrc but didn't want Tor to use them".

comment:4 Changed 8 years ago by anonym

Cc: anonym@… added

comment:5 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

ok, merged it. Have a look at the merge into 0.2.3; there were conflicts.

comment:6 Changed 7 years ago by nickm

Keywords: tor-client added

comment:7 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.