Opened 2 weeks ago

Closed 9 days ago

Last modified 9 days ago

#34196 closed defect (fixed)

Update site info URL with the onion name

Reported by: antonela Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ux-team TorBrowserTeam202005R
Cc: Actual Points:
Parent ID: Points:
Reviewer: sysrqb, antonela Sponsor:

Description (last modified by antonela)

After discussing onion names with the Freedom of the Press UX folks, they suggested showing a more explicit relationship between the origin .onion address and HTTPSeverywhere alias in our user interface.

We agreed on this idea and we planned to:

  • update the site info at the identity doorhanger by showing the onion name
  • allow users to see [more info]

Child Tickets

Attachments (6)

friendlyurl.png (359.3 KB) - added by antonela 2 weeks ago.
0.png (279.5 KB) - added by antonela 2 weeks ago.
TB9.5 stable - onion names
34196.png (83.4 KB) - added by acat 2 weeks ago.
34196_side.png (13.7 KB) - added by acat 2 weeks ago.
34196_moreinfo.png (77.2 KB) - added by acat 2 weeks ago.
pageinfo_onionname.png (67.9 KB) - added by acat 12 days ago.

Download all attachments as: .zip

Change History (21)

Changed 2 weeks ago by antonela

Attachment: friendlyurl.png added

comment:1 Changed 2 weeks ago by antonela

FPF's iteration
https://trac.torproject.org/projects/tor/raw-attachment/ticket/34196/friendlyurl.png

comment:2 Changed 2 weeks ago by antonela

Stable

https://trac.torproject.org/projects/tor/raw-attachment/ticket/34196/0.png

Changed 2 weeks ago by antonela

Attachment: 0.png added

TB9.5 stable - onion names

comment:3 Changed 2 weeks ago by acat

Patch for review in https://github.com/acatarineu/tor-browser/commit/34196.

I did not change the default styling, just replaced the site info URL. Not sure if the task also required to make "Site information for" nonbold.

Besides:

link users to a more info section in support.torproject.org/onionservices/onionnames

Does this require a change from my side? I don't see where this link could go in the images you attached.

Changed 2 weeks ago by acat

Attachment: 34196.png added

comment:4 Changed 2 weeks ago by acat

Keywords: TorBrowser202005R added
Status: newneeds_review

Changed 2 weeks ago by acat

Attachment: 34196_side.png added

Changed 2 weeks ago by acat

Attachment: 34196_moreinfo.png added

comment:5 Changed 2 weeks ago by acat

Actually, after taking a deeper look I revised the patch for a better approach I think: https://github.com/acatarineu/tor-browser/commit/34196+1 (00f5a4c995a911423e10af5a2bbeceef1ae76be6).

Also see the side panel https://trac.torproject.org/projects/tor/attachment/ticket/34196/34196_side.png and the more info window https://trac.torproject.org/projects/tor/attachment/ticket/34196/34196_moreinfo.png. The side panel still displays the friendly host, but more info window displays the actual, long .onion. I think this fine, but please review :)

comment:6 Changed 2 weeks ago by antonela

Description: modified (diff)

This is great. Also the [more info] link is the right place to show the origin onion as well.

I updated the ticket and after the code review, we can close it.

Thanks acat!

comment:7 Changed 2 weeks ago by eloquence

This looks great, thanks very much for the super quick iteration. On the SecureDrop team we're very excited about this functionality, as you can imagine. :-)

Is it feasible to add any additional data to the "More information" panel, e.g., to clarify the relationship between alias and .onion address?

Something like:

HTTPSEverywhere Alias: lucyparsonslabs.securedrop.tor.onion

(Or better terminology that's consistent with your goals for the project.)

comment:8 in reply to:  3 Changed 2 weeks ago by sysrqb

Replying to acat:

I did not change the default styling, just replaced the site info URL. Not sure if the task also required to make "Site information for" nonbold.

I agree, we should continue using Firefox's styling.

comment:9 in reply to:  7 ; Changed 2 weeks ago by sysrqb

Replying to eloquence:

Is it feasible to add any additional data to the "More information" panel, e.g., to clarify the relationship between alias and .onion address?

Something like:

HTTPSEverywhere Alias: lucyparsonslabs.securedrop.tor.onion

(Or better terminology that's consistent with your goals for the project.)

Are you imagining adding another line below "Website:" or "Verified by:"? I suggest we use a more generic term, like "Onion Alias" or "Onion Name".

comment:10 in reply to:  9 Changed 13 days ago by antonela

Replying to sysrqb:

more generic term, like "Onion Alias" or "Onion Name".

Both, Onion Alias or Onion Name works for me.

After this, we can stick to the picked version for our communication.

comment:11 Changed 13 days ago by asn

I like all of them. That said, I think "Alias" is a weird computer term. "Name" is a very simple term that everyone understands but perhaps might be confusing to people because then what's the onion address? But it also fits into the narrative of onion address is the IP address, and short-hand names are the DNS names. Another alternative would be "Onion Nickname".

All in all, I would go with anything here, with a small preference to "Name".

comment:12 in reply to:  5 Changed 13 days ago by sysrqb

Keywords: TorBrowser202005 added; TorBrowser202005R removed
Status: needs_reviewneeds_revision

Replying to acat:

Actually, after taking a deeper look I revised the patch for a better approach I think: https://github.com/acatarineu/tor-browser/commit/34196+1 (00f5a4c995a911423e10af5a2bbeceef1ae76be6).

The patch looks good, thanks! I merged it with commit 2e16915ff1a6933090dfb47e6fc876ea056cf07c.

I also opened #34225, for a later time.

I'll take the More Info panel patch as a fixup commit (but I wanted to land the above patch). We can get it into the alpha if it's ready by tomorrow night.

Changed 12 days ago by acat

Attachment: pageinfo_onionname.png added

comment:13 Changed 12 days ago by acat

Keywords: TorBrowser202005R added; TorBrowser202005 removed
Status: needs_revisionneeds_review

comment:14 Changed 9 days ago by sysrqb

Keywords: TorBrowserTeam202005R added; TorBrowser202005R removed
Resolution: fixed
Status: needs_reviewclosed

Thanks acat!

I merged the torbrowser fixup with commit a87a532c070322f8ba252da6a577c872d07d53b3, and the torbutton patch with 96321fdd1715f52cab00f6654ebc8fb420a5489d.

comment:15 Changed 9 days ago by antonela

\o/

Note: See TracTickets for help on using tickets.