Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#34204 closed defect (fixed)

Downgrade Travis stem version to a commit where tests pass.

Reported by: nickm Owned by: nickm
Priority: High Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: ci-failure 035-backport 041-backport 042-backport 043-backport
Cc: Actual Points: .3
Parent ID: Points:
Reviewer: Sponsor:

Description

Due to https://github.com/torproject/stem/issues/63 our CI is failing. Let's downgrade to a working version of Stem unless it gets fixed right away.

I have a test PR at https://github.com/torproject/tor/pull/1889 ; if CI passes, I'll make PRs for the other branches and put this in needs_review.

Child Tickets

Change History (8)

comment:1 Changed 2 months ago by nickm

Hm, no dice. We seem to be getting timeouts now. I wish I could use "git clone" to clone a commit rather than a tag or a branch. Investigating....

comment:2 Changed 2 months ago by nickm

Summary: Downgrade Travis stem version to 0.1.8.0Downgrade Travis stem version to a commit where tests pass.

force-pushed a new version that downgrades to the last known working commit rather than to 1.8.0.

comment:3 Changed 2 months ago by nickm

Quite odd! I think I am downgrading properly, but the stem tests are still failing in the same way.

comment:4 Changed 2 months ago by teor

Status: assignedneeds_revision

Try d1174a83 ?

The latest stem commit is a merge commit, and I read the wrong parent of the merge.

comment:5 Changed 2 months ago by nickm

Actual Points: .3
Status: needs_revisionneeds_review

Okay, after another force-push, travis seems to be passing on master.

Branches are:

All merges were trivial.

comment:6 Changed 2 months ago by ahf

Status: needs_reviewmerge_ready

Looks good.

comment:7 Changed 2 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged to 0.3.5 and forward.

comment:8 Changed 2 months ago by nickm

Created #34220 to revert this change once stem is fixed.

Note: See TracTickets for help on using tickets.