Opened 2 months ago

Closed 2 months ago

Last modified 6 weeks ago

#34224 closed defect (fixed)

Update analysis results file version to 2.0

Reported by: karsten Owned by: metrics-team
Priority: High Milestone:
Component: Metrics/Onionperf Version:
Severity: Normal Keywords:
Cc: metrics-team, acute, phw Actual Points: 0.2
Parent ID: Points: 0.2
Reviewer: Sponsor: Sponsor59-must


We added a new field to the analysis results file format in #26673, but we did not yet increment the format version number. The current version field is a floating point number, which doesn't work well for versioning. We should use a version string here. Given that this change alone is going to be backward-incompatible, we'll have to call the new version 2.0. I'm preparing a patch.

Child Tickets

Change History (4)

comment:1 Changed 2 months ago by karsten

Status: newneeds_review

phw or acute, would you like to review the relatively small commit d3dfb5b in my task-34224 branch?

comment:2 Changed 2 months ago by karsten

Resolution: fixed
Status: needs_reviewclosed

In retrospect, the patch is trivial enough to go into master without explicit review. After all, we concluded that the new version would be the string "2.0" on Thursday. Merging and closing.

comment:3 Changed 2 months ago by karsten

Actual Points: 0.2

comment:4 Changed 6 weeks ago by karsten

Sponsor: Sponsor59-must

This was part of Sponsor 59 work.

Note: See TracTickets for help on using tickets.