Opened 6 months ago

Last modified 6 months ago

#34225 new defect

Add shortName in nsIURI

Reported by: sysrqb Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam202009
Cc: acat Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


In #28805, we integrated the https-everywhere aliasing system for (securedrop) onion addresses. I think we can simplify the patch (and future patches) by including the alias/name within the current browser instance uri (browser.currentURI). We can achieve this by adding a shortName attribute (or something similar) in netwerk/base/nsIURI.idl. For simplicity, host can remain as the onion address, and we can add an additional attribute for the human-meaningful name.

(Naming is hard, but luckily this is an implementation detail so it doesn't really matter which attribute label we choose)

This will simplify patches where, in the current situation, we must pass around both the current uri and onionAliasURI.

Child Tickets

Change History (1)

comment:1 Changed 6 months ago by acat

That's a nice idea :)

Note: See TracTickets for help on using tickets.