Opened 6 months ago

Closed 6 months ago

#34252 closed defect (duplicate)

Fix Android x86_64 testbuild

Reported by: sysrqb Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords:
Cc: gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In #32788, we began using a constant build date in the testbuild. Unfortunately, on Android x86_64 (and I assume aarch64), we hit:

 0:02.07 Traceback (most recent call last):
 0:02.07   File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
 0:02.07     "__main__", fname, loader, pkg_name)
 0:02.07   File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
 0:02.07     exec code in run_globals
 0:02.07   File "/var/tmp/build/firefox-4acec7610371/python/mozbuild/mozbuild/action/file_generate.py", line 120, in <module>
 0:02.07     sys.exit(main(sys.argv[1:]))
 0:02.07   File "/var/tmp/build/firefox-4acec7610371/python/mozbuild/mozbuild/action/file_generate.py", line 71, in main
 0:02.07     ret = module.__dict__[method](output, *args.additional_arguments, **kwargs)
 0:02.07   File "/var/tmp/build/firefox-4acec7610371/mobile/android/base/generate_build_config.py", line 145, in generate_android_manifest
 0:02.07     defines=_defines(),
 0:02.07   File "/var/tmp/build/firefox-4acec7610371/mobile/android/base/generate_build_config.py", line 129, in _defines
 0:02.07     max_sdk=max_sdk)
 0:02.07   File "/var/tmp/build/firefox-4acec7610371/python/mozbuild/mozbuild/android_version_code.py", line 140, in android_version_code
 0:02.07     return android_version_code_v0(buildid, *args, **kwargs)
 0:02.07   File "/var/tmp/build/firefox-4acec7610371/python/mozbuild/mozbuild/android_version_code.py", line 31, in android_version_code_v0
 0:02.07     "for CPU arch %s" % cpu_arch)
 0:02.07 ValueError: Don't know how to compute android:versionCode for CPU arch x86_64
 0:02.07 make[4]: *** [backend.mk:11: .deps/AndroidManifest.xml.stub] Error 1
 0:02.07 make[4]: Leaving directory '/var/tmp/build/firefox-4acec7610371/obj-x86_64-linux-android/mobile/android/base'
 0:02.07 make[3]: *** [/var/tmp/build/firefox-4acec7610371/config/recurse.mk:101: mobile/android/base/export] Error 2
 0:02.07 make[3]: *** Waiting for unfinished jobs...

0:02.07 ValueError: Don't know how to compute android:versionCode for CPU arch x86_64

This is because the fixed build date (20010101010101) is less than 20150801000000, and this results in the Firefox build system using the old Android version code scheme which only supports x86 and armv7.

Child Tickets

Change History (1)

comment:1 Changed 6 months ago by gk

Resolution: duplicate
Status: newclosed

Yeah, I hit that, too, #34163.

Note: See TracTickets for help on using tickets.