Discussion on using a library for HTTP requests.

Since we are using POST request in long polling fashion to get the SDP offer from the broker and sending an answer. Since this is only a two-time use, do we need Retrofit library or if OkHttp is suffice. Retrofit uses OkHttp and it is a little bit bloated but feature-rich as compared to OkHttp.

Trac:
Parent Ticket: #34266 (moved)

added component::circumvention/snowflake parent::34266 priority::medium resolution::fixed severity::normal snowflake-mobile status::closed type::task labels

Trac:
Keywords: N/A deleted, snowflake-mobile added

Add snowflake-mobile keyword to Hashik's GSoC 2020 tickets.

Trac:
Keywords: N/A deleted, Snowflake_Android added

Trac:
Keywords: Snowflake_Android deleted, N/A added

Trac:
Cc: cohosh, phw, arlolra, dcf to cohosh, phw, arlolra, dcf, HashikD

Although I said OkHttp is suffice. Retrofit is feature-rich, like auto parsing of JSON objects, another main and important thing is it works very well and integrate well with RxJava (#34307 (moved)).

Besides, code looks much simpler and elegant with OkHttp.

Trac:
Status: new to needs_review

Link for okhttp

Link for retrofit

Sounds good to me.

Trac:
Status: needs_review to merge_ready

Added Retrofit library at commit id : 8c4725e5ad1db9a43d5b3a380a0bb0e59ddba267 Github Mirror

Trac:
Parent: N/A to #34266 (moved)

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

mentioned in issue #34266 (moved)

moved to tpo/anti-censorship/pluggable-transports/snowflake#34264 (closed)