Opened 6 days ago

Last modified 23 hours ago

#34264 merge_ready task

Discussion on using a library for HTTP requests.

Reported by: HashikD Owned by:
Priority: Medium Milestone:
Component: Circumvention/Snowflake Version:
Severity: Normal Keywords: snowflake-mobile
Cc: cohosh, phw, arlolra, dcf, HashikD Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Since we are using POST request in long polling fashion to get the SDP offer from the broker and sending an answer. Since this is only a two-time use, do we need Retrofit library or if OkHttp is suffice. Retrofit uses OkHttp and it is a little bit bloated but feature-rich as compared to OkHttp.

Child Tickets

Change History (9)

comment:1 Changed 6 days ago by cohosh

Keywords: snowflake-mobile added

comment:2 Changed 6 days ago by cohosh

Add snowflake-mobile keyword to Hashik's GSoC 2020 tickets.

comment:3 Changed 5 days ago by HashikD

Keywords: Snowflake_Android added

comment:4 Changed 5 days ago by HashikD

Keywords: Snowflake_Android removed

comment:5 Changed 2 days ago by cohosh

Cc: HashikD added

comment:6 Changed 45 hours ago by HashikD

Although I said OkHttp is suffice. Retrofit is feature-rich, like auto parsing of JSON objects, another main and important thing is it works very well and integrate well with RxJava (#34307).

Besides, code looks much simpler and elegant with OkHttp.

comment:7 Changed 44 hours ago by HashikD

Status: newneeds_review

comment:8 Changed 23 hours ago by cohosh

Link for okhttp

Link for retrofit

comment:9 Changed 23 hours ago by cohosh

Status: needs_reviewmerge_ready

Sounds good to me.

Note: See TracTickets for help on using tickets.