Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3432 closed enhancement (wontfix)

Cleaner start-tor-browser script for GNU/Linux bundle

Reported by: taylanub Owned by: erinn
Priority: Low Milestone:
Component: Applications/Tor bundles/installation Version: Tor: unspecified
Severity: Keywords: start-tor-browser script tbb linux
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

General cleanup increasing readability and robustness, adhering to POSIX and usual shell scripting conventions. See attachment or: http://ompldr.org/vOTRsNA

Child Tickets

Attachments (2)

start-tor-browser--new (2.5 KB) - added by taylanub 8 years ago.
start-tor-browser (new)
start-tor-browser (2.5 KB) - added by taylanub 8 years ago.
start-tor-browser (newer)

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by taylanub

Please ignore the linked version and see attachment only.

Changed 8 years ago by taylanub

Attachment: start-tor-browser--new added

start-tor-browser (new)

comment:2 Changed 8 years ago by taylanub

Stupid trac won't let me remove an attachment (only override).
Sorry for the mess. So much for late-night coding.

Changed 8 years ago by taylanub

Attachment: start-tor-browser added

start-tor-browser (newer)

comment:3 Changed 8 years ago by rransom

Resolution: wontfix
Status: newclosed

I've fixed the issue where TBB starts in debug mode if a user drags and drops a file onto start-tor-browser in commit 76596fca6bfd65df9502832d53e5e0f75ef01f4b on fixes-2011-08-23-01-master (see #2824). I don't see any other significant changes that we should use from your script, although it's quite hard for me to know for sure what other behaviour changes you made without a sequence of well-described diffs showing the intermediate steps in your reworking of the script.

Since I've had to rework start-tor-browser significantly myself in order to fix #2824 and a few other bugs, I don't think we can use your script now. Sorry.

comment:4 Changed 8 years ago by karsten

Keywords: tbb linux added
Milestone: Tor Browser Bundle for Linux
Note: See TracTickets for help on using tickets.