Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#3434 closed defect (fixed)

fix natpmp support

Reported by: ioerror Owned by: ioerror
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: arma Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Tor needs a minor update to link against libnatpmp-20110618 - this library is both very small and very frequently released.

Child Tickets

Change History (12)

comment:1 Changed 8 years ago by ioerror

I've made a change that will allow for tor-fw-helper to be built with natpmp support:
https://gitweb.torproject.org/ioerror/tor.git/shortlog/refs/heads/natpmp-fix

comment:2 Changed 8 years ago by arma

Owner: changed from ioerror to arma
Status: newaccepted

After this patch, would Tor now be incompatible with yesterday's libnatpmp?

Do any platforms ship with packages, or is this just something we can assume everybody's running today's version of?

comment:3 Changed 8 years ago by arma

Owner: changed from arma to ioerror
Status: acceptedassigned

comment:4 in reply to:  2 Changed 8 years ago by Sebastian

Replying to arma:

After this patch, would Tor now be incompatible with yesterday's libnatpmp?

Yes, that's why I didn't do this patch. We might want some version detection or so.

Do any platforms ship with packages, or is this just something we can assume everybody's running today's version of?

It's in Debian experimental. Version there is 20101211-1.

comment:5 Changed 8 years ago by ioerror

There has never been a proper release of libnatpmp and we have not frozen on a specific version. I didn't realize that it was in Debian experimental; perhaps we should freeze on that version and call it a day?

comment:6 Changed 8 years ago by ioerror

Sebastian, Shall I make a patch to ensure that it works against this package? http://packages.debian.org/experimental/libnatpmp0

comment:7 Changed 8 years ago by Sebastian

Hrm. There also seem to be ports for freebsd, so I think just defaulting to some version might not be good enough. That would also hurt us badly if a security issue is detected and users can't upgrade to the latest version

comment:8 Changed 8 years ago by ioerror

This is the same issue that we have for every library, why is the libnatpmp library different?

We need this functionality - I'm happy to code it up for a few different versions and to label it as experimental.

comment:9 in reply to:  8 Changed 8 years ago by nickm

Milestone: Tor: 0.2.3.x-final

Replying to ioerror:

This is the same issue that we have for every library, why is the libnatpmp library different?

Because it apparently doesn't have a stable API. Every other library we use provides backward compatibility.

The usual answer here is to declare a range of versions that we support, and work with all of those, writing our code so that it works with all of them.

comment:10 Changed 8 years ago by arma

Resolution: fixed
Status: assignedclosed

I just merged ioerror's patch. I don't think trying to maintain backward compatibility with something that was never released is going to be enough fun to make it worthwhile. Once they have a release we can talk.

(There is a thing in debian experimental, but sebastian says weasel says a package in experimental almost counts as not being in debian at all.)

comment:11 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:12 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.