Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#3437 closed defect (fixed)

obfsproxy should run on the Windows platform

Reported by: asn Owned by: asn
Priority: Medium Milestone:
Component: Archived/Obfsproxy Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

obfsproxy currently doesn't even compile on Windows.

Child Tickets

Change History (11)

comment:1 Changed 9 years ago by nickm

If you run into any hard-to-figure out errors, just upload them here; I've done a fair bit of port-it-to-windows before.

Or just do a "make -k" and upload it as an attachment.

comment:2 in reply to:  1 Changed 9 years ago by asn

Status: newneeds_review

Replying to nickm:

If you run into any hard-to-figure out errors, just upload them here; I've done a fair bit of port-it-to-windows before.

Or just do a "make -k" and upload it as an attachment.

I think I handled it.
Please check out my branch bug3437 :)

git://gitorious.org/obfsproxy/obfsproxy.git

comment:3 Changed 9 years ago by nickm

looks good except for the sockaddr_in6 thing: MSDN says that windows has socksaddr_in6 defined if you include the Ws2tcpip.h header.

In any case, it doesn't make sense to have a fake sockaddr_in6 here: it only makes sense to actually parse SOCKS5 requests to ipv6 addresses if the platform will actually let us connect to them. If the platform doesn't provide sockaddr_in6, making up our own won't do any good.

comment:4 Changed 9 years ago by asn

You are super right! Stupid me!

Please check again!

comment:5 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks good; merging.

comment:6 Changed 8 years ago by asn

Resolution: fixed
Status: closedreopened

Reopening this one, since the managed proxy changes introduced new compile conflicts for Windows.

I made a new branch bug3437_v2, which tries to resolve them.

(I did some brief tests with obfsproxy in managed mode on Windows today and it seemed to work OK.
I'll do more when tor_spawn_background() works on Windows normally (see #3656))

comment:7 Changed 8 years ago by asn

Status: reopenedneeds_review

comment:8 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks obviously safe; and if it builds for you then that's an improvement. Merging.

comment:9 Changed 8 years ago by asn

I managed to introduce an error in that minuscule commit.
Commit b4cb4281 "fixes" it.

comment:10 Changed 8 years ago by nickm

merged that

comment:11 Changed 8 years ago by arma

Component: Pluggable transportObfsproxy
Note: See TracTickets for help on using tickets.