Opened 5 months ago

Last modified 5 months ago

#34382 needs_review defect

Don't require M_SYSCALL in sandbox.c

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: easy fast-fix 044-can
Cc: Actual Points: 0
Parent ID: Points: 0.1
Reviewer: dgoulet Sponsor:

Description

In sandbox.c, we have a platform-dependent M_SYSCALL macro that is used to extract the syscall from a ucontext_t pointer.

But we only use this value for debugging. Perhaps instead we should make it optional, so that platforms where we don't have it defined can still build with m_syscall.

See also #32904 and #30987

Child Tickets

Change History (4)

comment:1 Changed 5 months ago by nickm

Status: assignedneeds_review

See branch ticket34382 with PR at https://github.com/torproject/tor/pull/1919

comment:2 Changed 5 months ago by nickm

Actual Points: 0

comment:3 Changed 5 months ago by nickm

Keywords: 044-can added

comment:4 Changed 5 months ago by asn

Reviewer: dgoulet
Note: See TracTickets for help on using tickets.