Investigate connections bypassing FPI in 78

When I visit a page by typing it's address in the urlbar, I can see one connection being authenticated with the --unknown-- username. I guess it will be the favicon. Need to investigate and fix.

added component::applications/tor browser ff78-esr owner::tbb-team priority::medium resolution::invalid severity::normal status::closed type::defect labels

favicons were FPI'd in https://bugzilla.mozilla.org/show_bug.cgi?id=1277803

Maybe this is it: https://bugzilla.mozilla.org/show_bug.cgi?id=1475811 ? Edit: ok, that's was covered in #26353 (moved)

Yeah, I also had discarded that for being covered in #26353 (moved), but... it turns out I missed that patch in #33533 (moved), while switching from branch 31918+2 to 33533+5 :(

So, that seems to be the reason, closing this.

Trac:
Resolution: N/A to invalid
Status: new to closed

Replying to acat:

but... it turns out I missed that patch

Not my error of expertise TBH (and OT, but related), but can I ask what mitigations are in place to catch these sorts of things

Reviews (ongoing) and for some patches, tests. Ideally, we'd have tests for every single patch, but not there yet.

Bit of a catch-22 when the test is part of the patch ") but I know what you mean

closed

moved to tpo/applications/tor-browser#34413 (closed)