Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#3456 closed defect (fixed)

Flags in cpath_build_state_t should be one-bit bitfields, not ints

Reported by: rransom Owned by: rransom
Priority: Very Low Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

  /** Whether every node in the circ must have adequate uptime. */
  int need_uptime;
  /** Whether every node in the circ must have adequate capacity. */
  int need_capacity;
  /** Whether the last hop was picked with exiting in mind. */
  int is_internal;
  /** Did we pick this as a one-hop tunnel (not safe for other conns)?
   * These are for encrypted connections that exit to this router, not
   * for arbitrary exits from the circuit. */
  int onehop_tunnel;

unsigned int foo : 1; would be more appropriate here.

Child Tickets

Change History (4)

comment:1 Changed 8 years ago by rransom

Status: newneeds_review

See bug3456 ( git://git.torproject.org/rransom/tor.git bug3456 ) for a fix for this and a minor comment correction. I didn't add a changes/ file because this shouldn't change any behaviour.

comment:2 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks fine; merging.

comment:3 Changed 7 years ago by nickm

Keywords: tor-client added

comment:4 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.