Opened 8 years ago

Closed 8 years ago

#3530 closed defect (fixed)

torify script may use tsocks

Reported by: rransom Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Torify Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The torify script shipped with Tor in the contrib/ directory (and installed by make install) may use tsocks, which leaks DNS queries. If we continue to ship it at all, it should only try to use torsocks.

Child Tickets

Attachments (1)

torify (890 bytes) - added by ugh 8 years ago.
whoops, added missing redirection to stderr for -v/--verbose compatiblity message

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by rransom

Component: Tor ClientTorify
Priority: majorcritical

comment:2 Changed 8 years ago by arma

Milestone: Tor: 0.2.2.x-finalTor: 0.2.3.x-final
Priority: criticalnormal

Is there a torsocks deb?

I don't think we should break torify's functionality at the last moment with no warning in Tor 0.2.2.x.

Resolving it in the 0.2.3.x timeframe is a fine plan, and once we see how we've resolved it, we can ponder if a backport would upset too many packagers.

That said, who will bell the cat?

comment:3 in reply to:  2 Changed 8 years ago by intrigeri

Replying to arma:

Is there a torsocks deb?

There is: http://packages.qa.debian.org/t/torsocks.html

comment:4 Changed 8 years ago by ugh

I've attached a torify script that removes all the tsocks code. It would then just be a compatibility shim around torsocks that does the right thing for -v/--verbose or -h/--help arguments.

Changed 8 years ago by ugh

Attachment: torify added

whoops, added missing redirection to stderr for -v/--verbose compatiblity message

comment:5 Changed 8 years ago by nickm

Status: newneeds_review

ugh's patch is tweaked in my branch "bug5180" in my public repo; please review. See also #5180.

comment:6 Changed 8 years ago by rransom

ugh's script has no bugs or uglinesses that weren't in the previous torify script. I like it.

comment:7 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

ok, merged. Thanks!

Note: See TracTickets for help on using tickets.