Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3551 closed defect (fixed)

obfsproxy: Be consistent on the function return convention

Reported by: asn Owned by: asn
Priority: Medium Milestone:
Component: Archived/Obfsproxy Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: #3591 Points:
Reviewer: Sponsor:

Description

The current code is a bastard mix of:
"-1 on fail, 1 on success" and "-1 on fail, 0 on success"

We MUST standarize that.
We should probably go with "-1 on fail, 0 on success" to match with tor's convention.

Child Tickets

Change History (4)

comment:1 Changed 8 years ago by asn

Status: newneeds_review

Okay, I converted the current master branch.
You can find it in my bug3551 @ git://gitorious.org/obfsproxy/obfsproxy.git

comment:2 Changed 8 years ago by asn

Parent ID: #3591

comment:3 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged

comment:4 Changed 8 years ago by arma

Component: Pluggable transportObfsproxy
Note: See TracTickets for help on using tickets.