Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#3565 closed defect (implemented)

Cache and retry optimistic data on failure

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: #1849 Points:
Reviewer: Sponsor:

Description

Perhaps we should remember the data that we've sent out optimistically on a stream, and retry it if the stream fails.

Child Tickets

Attachments (2)

opt_test_ctrl.py (3.9 KB) - added by iang 8 years ago.
Test controller for this ticket
optlog.diff (888 bytes) - added by iang 8 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by nickm

Status: newneeds_review

Needs_review now: see my branch "optimistic-client" in my public repository.

comment:2 Changed 8 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

comment:3 Changed 8 years ago by iang

Has this been tested?

comment:4 Changed 8 years ago by nickm

Nope.

Changed 8 years ago by iang

Attachment: opt_test_ctrl.py added

Test controller for this ticket

comment:5 Changed 8 years ago by iang

I have successfully tested it. I've attached the controller script I used, which attaches user streams to a succession of non-exit circuits, some of which support optimistic data and some which do not, before finally connecting it to an exit circuit, which succeeds.

I might suggest applying the attached diff, to make the log message a little more useful.

Changed 8 years ago by iang

Attachment: optlog.diff added

comment:6 Changed 8 years ago by nickm

Thanks; applied!

comment:7 Changed 7 years ago by nickm

Keywords: tor-client added

comment:8 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.