Opened 8 years ago

Closed 8 years ago

#3578 closed defect (fixed)

180-pluggable-transport.txt changes

Reported by: asn Owned by: asn
Priority: Medium Milestone:
Component: Circumvention/Pluggable transport Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: #3591 Points:
Reviewer: Sponsor:

Description

While implementing 180-pluggable-transport.txt, I changed a couple of things in the spec.

You can find the changes I made so far in 'proposal_180' branch in my git://gitorious.org/torspec/torspec.git repo.

Comments are most welcome :)

PS: Hope this is the correct category for this.

Child Tickets

Change History (8)

comment:1 Changed 8 years ago by asn

Status: newneeds_review

I'll put this in needs_review even though it's not final, so that someone looks at this and tells me whether I'm doing it wrong.

comment:2 Changed 8 years ago by nickm

Dropping the "proxy" in you

-     ServerTransportPlugin method proxy address:port param=val..
+     ServerTransportPlugin <method> <address:port> <param=val> ...

seems to serve no real purpose.

Why did you change the addr:portnum stuff EXTENDED_SERVER_PORT, ORPORT, to be just "Port"? That also seems needless.

comment:3 in reply to:  2 Changed 8 years ago by asn

Replying to nickm:

Dropping the "proxy" in you

-     ServerTransportPlugin method proxy address:port param=val..
+     ServerTransportPlugin <method> <address:port> <param=val> ...

seems to serve no real purpose.

Oh, I thought that 'proxy' was just forgotten there from the ClientTransportPlugin line, and that we would distinguish between managed and external proxy lines by testing for '.' and ':' like we distinguish old-style and new-style Bridge lines.
I guess I'll leave 'proxy' there then.

Why did you change the addr:portnum stuff EXTENDED_SERVER_PORT, ORPORT, to be just "Port"? That also seems needless.

I'm not sure; I was probably driven away by the FOO_PORT name.

Do pull again for a second revision with the above issues fixed.

comment:4 Changed 8 years ago by asn

Parent ID: #3591

comment:5 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

MErged; thanks

comment:6 Changed 8 years ago by asn

Resolution: fixed
Status: closedreopened

Reopening this ticket to sneak in some trivial changes.
See my branch bug3578 @ git://gitorious.org/torspec/torspec.git

comment:7 Changed 8 years ago by asn

Status: reopenedneeds_review

comment:8 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged; thanks!

Note: See TracTickets for help on using tickets.