UseMicrodescriptors 1 breaks hidden service connectivity

Making any kind of hidden service connection attempt gives an immediate "[scrubbed].onion': hidden service is unavailable (try again later)." log message, and the request fails.

changed milestone to %Tor: 0.2.3.x-final

added component::core tor/tor milestone::Tor: 0.2.3.x-final parent::1748 priority::high resolution::fixed status::closed tor-client type::defect version::tor 0.2.3.1-alpha labels

Trac:
Parent: N/A to #1748 (moved)

Weird; I just tried the duckduckgo hidden service and it worked okay for me. Are there any other configuration issues going on? Is there anything suggestive in your info logs? Is there anything to suggest how far the connection is getting before it dies?

You did this in a data directory that used to have a non-md tor in it, yes? If I do that then hidden services work for me too, but using a clear data directory makes it break. Investigating logs now

Oh, right you are. When I delete cached-descriptors*, it stops working.

Jul 15 18:35:04.000 [info] connection_ap_handshake_rewrite_and_attach(): Got a hidden service request for ID '3g2upl4pq6kufc4m'
Jul 15 18:35:04.000 [info] connection_ap_handshake_rewrite_and_attach(): Unknown descriptor 3g2upl4pq6kufc4m. Fetching.
Jul 15 18:35:04.000 [info] directory_get_from_hs_dir(): Could not pick one of the responsible hidden service directories, because we requested them all recently without success.
Jul 15 18:35:04.000 [info] directory_get_from_hs_dir(): Could not pick one of the responsible hidden service directories, because we requested them all recently without success.
Jul 15 18:35:04.000 [info] rend_client_refetch_v2_renddesc(): Could not pick one of the responsible hidden service directories to fetch descriptors, because we already tried them all unsuccessfully.

Aha, the "router_get_by_id_digest()" in directory_get_from_hs_dir() is probably to blame. It should check for a usable node_t, not for a routerinfo.

Oh hey; publishing hidden service descriptors has the same bug!

See branch bug3601 in my public repository.

Trac:
Status: new to needs_review
Priority: normal to major

Fix looks good. Tested it for the client use case, too.

Great; I've merged it!

(thwunk)

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Trac:
Keywords: N/A deleted, tor-client added

Trac:
Component: Tor Client to Tor

closed

moved to tpo/core/tor#3601 (closed)