Opened 9 years ago

Closed 8 years ago

#3634 closed enhancement (fixed)

Better support of multiple tor relays

Reported by: joergent Owned by: chiiph
Priority: Medium Milestone:
Component: Archived/Vidalia Version: Vidalia: 0.2.12
Severity: Keywords:
Cc: opensource@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Vidalia should display the nickname of the tor relay connected to in the title bar of all windows.

Child Tickets

Change History (11)

comment:1 Changed 9 years ago by joergent

Cc: opensource@… added

comment:2 Changed 9 years ago by chiiph

I don't quite understand what you mean.

Are you talking about when Vidalia is used to configure a relay? Or is this something regarding the circuits in use?

comment:3 Changed 9 years ago by joergent

I load two instances of Vidalia. One for each of my two tor relays.
The windows displayed are totaly identically and undistinguishable.
I cannot tell which bandwith display is from which tor.

comment:4 Changed 9 years ago by arma

Interesting idea. But with a default nickname of Unnamed, I expect putting the word Unnamed in all the Vidalia windows is going to create a lot more confusion and "bug" reports.

I wonder if this is one of those cases where adding a hidden option somewhere would be enough -- I think very few people use Vidalia in the way you're describing.

comment:5 in reply to:  4 Changed 9 years ago by joergent

Replying to arma:

Interesting idea. But with a default nickname of Unnamed, I expect putting the word Unnamed in all the Vidalia windows is going to create a lot more confusion and "bug" reports.

If Unnamed, then use the control port address:port

I wonder if this is one of those cases where adding a hidden option somewhere would be enough -- I think very few people use Vidalia in the way you're describing.

Why complicate things using options?
It will not hurt anything to add a litte more information to the title bar.

comment:7 Changed 8 years ago by chiiph

Status: needs_reviewneeds_revision

Three minor things and we are there:

  • This:
setWindowTitle(baseTitle + " - " + Nickname + " " + ORPort);

Should be something like this:

setWindowTitle(QString("%1 - %2 %3").arg(baseTitle)
                                    .arg(Nickname)
                                    .arg(ORPort));

So that the format is easy to change.

  • The line with "this" in the connect is badly indented.
  • You probably want to emit the configChanged() signal only when something was changed, not all the time. In fact, we just want it the times ServerPage changed, but since the signal is pretty generic, we will have to emit it when any page has changed.

comment:8 Changed 8 years ago by feroze

Status: needs_revisionneeds_review

comment:9 Changed 8 years ago by chiiph

Status: needs_reviewneeds_revision

The changes file should be exactly like this:

  New features:
  o Display the relay Nickname and ORPort in the window title when
    Vidalia is running as a relay. Fixes bug 3634.

Notice where the line ends (i.e. how many columns the formatting has), and how the category is placed before the message.

Also, you should not edit the CHANGELOG directly, I (or whoever makes the release) will generate the CHANGELOG based on the changes files. If a changes file is already in the CHANGELOG it should not exist in the changes directory.

Other than that, looks good, please fix that and make sure you understand what the CHANGELOG workflow is with these last final touches.

comment:11 Changed 8 years ago by chiiph

Resolution: fixed
Status: needs_reviewclosed

Great, merged. It will be out with 0.3.2. Thanks!

Note: See TracTickets for help on using tickets.