Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3666 closed defect (fixed)

SafeCache key is only 32bit

Reported by: mikeperry Owned by: mikeperry
Priority: High Milestone: TorBrowserBundle 2.2.x-stable
Component: Firefox Patch Issues Version:
Severity: Keywords: MikePerryIteration20110911 backport-to-mozilla
Cc: g.koppen@…, StrangeCharm, erinn Actual Points: 2
Parent ID: #2871 Points: 5
Reviewer: Sponsor:

Description

We need to extend the key that safecache uses either to a 64bit int, or just add an additional string key. 32bits is too small: the birthday paradox says that 1 in every 64k domains will collide to the same id, allowing identifier sharing.

Child Tickets

Attachments (1)

0001-Bug-3455.3-Add-DomainIsolator-for-isolating-circuit-.patch (7.2 KB) - added by arthuredelstein 5 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by mikeperry

Points: 5

comment:2 Changed 8 years ago by rransom

If the hash function is publicly known, its output should be at least 160 bits long, and preferably closer to 256 bits.

comment:3 Changed 8 years ago by gk

Cc: g.koppen@… added

comment:4 Changed 8 years ago by mikeperry

Keywords: MikePerryIteration20110911 added

comment:5 Changed 8 years ago by mikeperry

Actual Points: 2
Cc: StrangeCharm erinn added
Parent ID: #2871
Resolution: fixed
Status: newclosed

I created a cacheDomain in nsICachingChannel. Patch is in my torbrowser.git remote mikeperry/bug3907+3666.

comment:6 Changed 8 years ago by StrangeCharm

Keywords: backport-to-mozilla added

comment:7 Changed 8 years ago by rransom

Keywords: MikePerryIteration20110911, backport-to-mozillaMikePerryIteration20110911 backport-to-mozilla
Note: See TracTickets for help on using tickets.