Learn how to write your own rulesets link opens window that you can't scroll in

To reproduce:

• Go to HTTPS preferences
• Click the link at the bottom of the preferences screen
• A browser window without chrome is opened and you can't scroll the page to read all of the information

It should just open the page in a browser tab

Trac:
Username: henare

added component::https everywhere/eff-https everywhere owner::jacobske87 priority::medium reporter::henare resolution::fixed status::closed type::defect labels

Trac:
Component: - Select a component to EFF-HTTPS Everywhere
Owner: N/A to pde

Confirmed bug, and I copied over a potential fix from my own extension. I don't have Tor installed so I haven't tested with that (regarding the state control button comment line), but since it uses the same window I don't think it should cause any problems.

I think the added tab is much more user friendly than opening a new window.

Code change is here: https://github.com/kevinjacobs/HTTPS-Everywhere/commit/6b6c50e6b925b13356063b1bb589fe834ccc77bd (ignore the deleted folder change)

Trac:
Username: jacobske87
Cc: N/A to jacobske87@gmail.com
Owner: pde to jacobske87
Status: new to assigned

Looks ok, except I think that browser will always be undefined because this code executes from the about.xul window.

Have you successfully tested it w/ torbutton?

As for the undefined browser (if/else).. You're probably right, I just copied it from my code where it's intended to be reusable (so I can call the same method when browser is defined). It will still work but the if/else is up to you whether you'd want in there or not.

I won't be able to test with Tor until this weekend. I'll give it a try and post my results.

Trac:
Username: jacobske87

Trac:
Username: jacobske87

https-everywhere-latest.xpi

Possible fix (please verify with Tor)

Trac:
Username: jacobske87

It seems to work with Tor just fine for me. I'm not really a Tor user though, so it would be better if someone who knows it could verify that the fix is safe..

I attached the modified XPI for you to test. Thanks

Trac:
Username: jacobske87
Status: assigned to needs_review

Fix committed:

https://gitweb.torproject.org/https-everywhere.git/commit/a947b1ab107e709eaba90950f5c9518201db928f

Marking this as fixed.

Trac:
Username: jacobske87
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/https-everywhere-eff#3696 (closed)