Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#3703 closed defect (fixed)

Tor 0.2.3.2 doesn't build without warnings on windows

Reported by: Sebastian Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I'm getting a signed/unsigned comparison warning here. Not sure if this is windows 7 specific (karsten and I are seeing this) or if our 0.2.3.2 bundles just weren't built with warnings enabled

Child Tickets

Change History (6)

comment:1 Changed 8 years ago by Sebastian

Status: newneeds_review

Branch bug3703 fixes this and another warning I found, it now compiles without warnings for me. Other people should maybe test other versions of windows? I didn't make a changes file, seems minor enough. Happy to add one if I should.

comment:2 Changed 8 years ago by karsten

Sebastian gave me a tarball that fixes these warnings and then runs into the #3692 problem.

comment:3 Changed 8 years ago by Sebastian

karsten just tested a new tarball that also includes the #3692 fix, and tor compiled without warnings for him too.

comment:4 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks good ; merged.

comment:5 Changed 7 years ago by nickm

Keywords: tor-client added

comment:6 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.