Report version of bwscanners in votes

Each directory authority should list the git version of the bandwidth scanners in their votes. This ticket has two parts:

1. Edit aggregate.py to output a line with the git commit that it is from.

2. Alter the tor voting to add an "opt" line or other ignored keyword that lists the version from the bwscan file.

There should be no consensus process for this. We just want a comment in the vote documents, basically.

changed milestone to %Tor: 0.3.5.x-final

added 035-triaged-in-20180711 component::core tor/tor milestone::Tor: 0.3.5.x-final parent::25925 priority::medium resolution::implemented reviewer::teor severity::normal status::closed tor-bwauth type::enhancement labels

Trac:
Cc: N/A to karsten, aagbsn

Trac:
Priority: normal to major

Trac:
Owner: mikeperry to aagbsn
Status: new to assigned

This is a feature that belongs in the new bwauth replacement project, see #13630 (moved).

Trac:
Reviewer: N/A to N/A
Severity: N/A to Blocker
Parent: N/A to #13630 (moved)
Sponsor: N/A to N/A

Priorities and Severities in torflow are meaningless, setting them all to Medium/Normal.

Trac:
Severity: Blocker to Normal
Priority: High to Medium

aagbsn was the default owner, unassigning

Trac:
Owner: aagbsn to N/A

Mark all tickets that are assigned to nobody as "new".

Trac:
Status: assigned to new

Hi juga, this is the ticket for putting the bandwidth authority version in votes.

We are working on the file format in #25869 (moved) and https://github.com/torproject/torspec/pull/4

I think we should:

1. add a "timestamp=" to the timestamp
2. turn the entire bwfile header into a single line
3. put it all in the vote as a line with a new keyword, "bandwidth-file"

For bandwidth file format 1.0.0, the line would be: bandwidth-file timestamp=1234567890

For bandwidth file format 1.1.0, the line would be: bandwidth-file timestamp=1234567890 version=1.1.0 software=sbws software_version=0.1.0

If we implement the feature in this way, then Tor will automatically add new fields to the bandwidth-file line.

Trac:
Cc: karsten, aagbsn to juga, karsten, aagbsn
Component: Core Tor/Torflow to Core Tor/Tor
Milestone: N/A to Tor: unspecified

This is about the format of the vote line, not the format of the v3bwfile header, which is multiple lines.

Replying to teor:

Hi juga, this is the ticket for putting the bandwidth authority version in votes.

We are working on the file format in #25869 (moved) and https://github.com/torproject/torspec/pull/4

I think we should:

1. add a "timestamp=" to the timestamp
2. turn the entire bwfile header into a single line
3. put it all in the vote as a line with a new keyword, "bandwidth-file"

For bandwidth file format 1.0.0, the line would be: bandwidth-file timestamp=1234567890

For bandwidth file format 1.1.0, the line would be: bandwidth-file timestamp=1234567890 version=1.1.0 software=sbws software_version=0.1.0

If we implement the feature in this way, then Tor will automatically add new fields to the bandwidth-file line.

Trac:
Parent: #13630 (moved) to 25925

Trac:
Parent: 25925 to #25925 (moved)

To which Tor version should we backport this?, 0.3.2 too since it's the ealier version dirauths are running?

Would be the place to put the one i'm using in this commit?: https://github.com/juga0/tor/commit/dd19df3a042e9b9bbf29fdb73d717a78f7dc5e57#diff-141d60fb101694336aa8683a8e2a1541R241

In which structure should the timestamp (and version) be stored so that dirvote.c can read it?.

Replying to juga:

To which Tor version should we backport this?, 0.3.2 too since it's the ealier version dirauths are running?

New features do not get backported, they get merged to master.

Since there is an 0.3.4 alpha release, it is closed to new features. So the earliest release this feature will be in is 0.3.5.

Would be the place to put the one i'm using in this commit?: https://github.com/juga0/tor/commit/dd19df3a042e9b9bbf29fdb73d717a78f7dc5e57#diff-141d60fb101694336aa8683a8e2a1541R241

That is almost the right place. Please add the new "bandwidth-file" line to the end of the authority header, after the shared random information. We add new lines to the end of the section, to avoid merge conflicts.

In which structure should the timestamp (and version) be stored so that dirvote.c can read it?.

Please add every header key_value to the bandwidth-file line, not just timestamp and version. This means that new header lines are automatically added to the vote.

You can add these key_values to a space-separated string.

I suggest that you modify dirserv_read_measured_bandwidths() to store the headers in a string, add a function that gets that string, and include the string in the vote.

1. Set the bandwidth-file string to NULL at the start of the function, freeing it if was not NULL: https://github.com/torproject/tor/blob/1eede00a4bd9a7de2acf77393f2fc57aa3196d08/src/or/dirserv.c#L2584

2. Once you know the time is a number, read the rest of the header lines, and add them to the bandwidth-file string: https://github.com/torproject/tor/blob/1eede00a4bd9a7de2acf77393f2fc57aa3196d08/src/or/dirserv.c#L2615

3. When voting, add a bandwidth-file line if the bandwidth-file string is not NULL: https://github.com/juga0/tor/commit/dd19df3a042e9b9bbf29fdb73d717a78f7dc5e57#diff-141d60fb101694336aa8683a8e2a1541R210

You will also need to change the dir-spec. I will open a child ticket.

Trac:
Milestone: Tor: unspecified to Tor: 0.3.5.x-final

Since it is not being backported i based it on master, now in my branch ticket3723

After looking more to dirvote.c i thought it was better to use smartlist_t instead of string, and get it converted to string in format_networkstatus_vote.

Since dirserv_read_measured_bandwidths is call from dirserv_generate_networkstatus_vote_obj, i don't need a different function to obtain the headers.

Since i didn't found specific tests for dirserv_generate_networkstatus_vote_obj and format_networkstatus_vote, i'm not sure how to add tests for the vote document.

This code break other tests, hints?.

Trac:
Keywords: N/A deleted, tor-dirauth added

Trac:
Status: new to needs_review

Replying to juga:

This code break other tests, hints?. solved.

Trac:
Keywords: tor-dirauth deleted, tor-bwauth added

Trac:
Reviewer: N/A to teor