Opened 8 years ago

Closed 7 years ago

#3755 closed defect (fixed)

memory leak

Reported by: arno Owned by: mikeperry
Priority: High Milestone: TorBrowserBundle 2.2.x-stable
Component: TorBrowserButton Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Hi,
I discovered a memory leak with torbutton.
This can be checked with a debug build of Firefox. Alternatively, an assertion is triggered in cairo library
firefox: /tmp/buildd/cairo-1.10.2/src/cairo-hash.c:196: _cairo_hash_table_destroy: Assertion `hash_table->live_entries == 0' failed.
It looks like a window object is not released.

I could track it to torbutton_wrap_search_service.
I looks like setting origEngineObj.getSubmission function causes the leak. The fix would be to get the object back at unload, and set getSubmission method function to null.
I won't provide a patch right now because I did not clearly understood if the getSubmission replacement is done once or for each window.

Child Tickets

Change History (3)

comment:1 Changed 8 years ago by mikeperry

Component: TorbuttonTorBrowserButton

comment:2 Changed 8 years ago by mikeperry

Milestone: TorBrowserBundle 2.2.x-stable
Priority: normalmajor

comment:3 Changed 7 years ago by mikeperry

Resolution: fixed
Status: newclosed

This code is now disabled as part of the cleanup tickets (#5279 and others).

Note: See TracTickets for help on using tickets.