Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#3804 closed defect (fixed)

Bufferevent rate-limiting logic handles filtering badly

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: #3561 Points:
Reviewer: Sponsor:

Description

When we're doing filtering ssl bufferevents, we want the rate-limits to apply to the lowest level of the bufferevent stack, so that we're actually limiting bytes sent on the network. Otherwise, we'll read from the network ad libitum.

Also, we need to set write high-water marks for the lowest-level bufferevents in the filtering stack, or else we might prematurely ssl-ify data faster than we could write it, which would be silly.

Child Tickets

Change History (4)

comment:1 Changed 8 years ago by nickm

Status: newneeds_review

Fix for this is in branch bufev_ratelim_and_wm

comment:2 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged it.

comment:3 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:4 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.