Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#3805 closed defect (fixed)

With bufferevents, flushed_some isn't called enough

Reported by: nickm Owned by:
Priority: High Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: #3561 Points:
Reviewer: Sponsor:

Description

We're relying on bufferevent write callbacks to invoke connection_flushed_some(). But we're never setting a low-watermark for the bufferevents, so they'll only get invoked when we're actually flushed.

Child Tickets

Change History (4)

comment:1 Changed 8 years ago by nickm

Status: newneeds_review

Fix for this is in branch bufev_ratelim_and_wm

comment:2 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged it.

comment:3 Changed 7 years ago by nickm

Keywords: tor-client added

comment:4 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.