Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#3832 closed enhancement (fixed)

Add getinfo controller commands to fetch microdescs

Reported by: Sebastian Owned by:
Priority: High Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: chiiph, the.magical.kat@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

katmagic reports she's getting Unrecognized key "desc/name/blutmagie" replies.

Child Tickets

Change History (11)

comment:1 Changed 8 years ago by nickm

Isn't this to be expected? If you're not fetching descriptors, you wouldn't expect to have them lying around.

comment:2 Changed 8 years ago by Sebastian

Wouldn't we want to give you the microdescriptor then? Or maybe a more helpful error message? katmagic was surprised when suddenly her tor didn't have descriptors for her anymore after an upgrade

comment:3 Changed 8 years ago by nickm

A better error message would be fine; something like a rate-limited log message, plus a 55x error of some kind.

There should be another GETINFO option that returns microdescriptors IMO overloading "desc" to mean "either desc or md, whichever you have" seems like it will only cause more problems in the long run.

comment:4 Changed 8 years ago by arma

Parent ID: #4203
Priority: normalmajor
Summary: With microdescs enabled, GETINFO desc/name/<nickname> queries failAdd getinfo controller commands to fetch microdescs
Type: defectenhancement

Marking this ticket as the child of #4203, since it needs to be done before Vidalia can make its network map work again.

comment:5 Changed 8 years ago by rransom

Parent ID: #4203
Status: newneeds_review

See bug3832 ( https://git.torproject.org/rransom/tor.git bug3832 ) for a Tor patch.

Removing the parent ticket number (#4203), because our Trac instance is broken (Warning: The parent ticket (#4203) has type defect which does not allow child tickets.).

comment:6 Changed 8 years ago by rransom

Cc: chiiph added

comment:7 Changed 8 years ago by rransom

See bug3832 ( https://git.torproject.org/rransom/torspec.git bug3832 ) for a corresponding control-spec.txt patch.

comment:8 Changed 8 years ago by katmagic

Cc: the.magical.kat@… added

I've tested rransom's patch—it works well.

comment:9 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks okay to me. Merging.

comment:10 Changed 7 years ago by nickm

Keywords: tor-client added

comment:11 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.