Opened 9 years ago

Last modified 6 months ago

#3863 reopened task

Do something smarter with Windows Tor crash dumps

Reported by: arma Owned by: tbb-team
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: windows
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Right now, it's my understanding that when Tor crashes on Windows, users get to choose whether to send their crash dump to Microsoft.

We should either pay the protection money so we can sign up to get the crash dumps instead, and build our packages in a way that sends the dumps our way; or we should disable sending crash dumps.

Is this issue specific to Tor-the-program, or should we be considering other bundle components too?

Child Tickets

Change History (18)

comment:1 Changed 9 years ago by mo

"Add code to your project. Add the MiniDumpWriteDump function and the appropriate exception handling code to save and send a minidump directly to the developer. This article demonstrates how to implement this option. However, note that MiniDumpWriteDump does not currently work with managed code and is only available on Windows XP, Windows Vista, Windows 7."

http://msdn.microsoft.com/en-us/library/ee416349%28v=vs.85%29.aspx

comment:2 Changed 9 years ago by erinn

I think we should also do this for Vidalia. I know chiiph has been working on adding breakpad support to Vidalia, and if I am remembering correctly, he already has it, but we have to begin building Vidalia (and possibly the rest of the toolchain) with nmake. So there's a subticket in here for me somewhere having to do with "port Windows toolchain to actual Windows build system."

comment:3 Changed 9 years ago by erinn

By Windows toolchain, I mean all of the Tor-related components. I haven't investigated how many of them do or do not already build in Visual Studio / with nmake. But Nick and I worked on porting Tor itself to nmake recently, so I know that is partially done.

comment:4 in reply to:  3 Changed 9 years ago by arma

Replying to erinn:

By Windows toolchain, I mean all of the Tor-related components. I haven't investigated how many of them do or do not already build in Visual Studio / with nmake. But Nick and I worked on porting Tor itself to nmake recently, so I know that is partially done.

Added #3864 to track the Tor-specific component of that progress.

comment:5 Changed 9 years ago by sjmurdoch

If we go the route of disabling error reporting, a patch to do this can be found in my branch "disable-error-reporting" in git://git.torproject.org/sjm217/tor.git. The diff is https://gitweb.torproject.org/sjm217/tor.git/commitdiff/8f0cb16829de985bea8b815f9bd6c8bc2ae2c81d

comment:6 Changed 8 years ago by sjmurdoch

Perhaps we should also disable Customer Experience Improvement Program? http://technet.microsoft.com/en-us/library/cc753606%28v=ws.10%29.aspx

comment:7 Changed 6 years ago by erinn

Keywords: needs-triage added

comment:8 Changed 6 years ago by erinn

Component: Tor bundles/installationTor Browser
Owner: changed from erinn to tbb-team

comment:9 Changed 2 years ago by teor

Severity: Normal

Set all open tickets without a severity to "Normal"

comment:10 Changed 6 months ago by gk

Resolution: worksforme
Status: newclosed

We have #23624 for a smarter crash reporter deployment. The problem in this bug is gone, though, as Windows users are not prompted anymore to send their Tor Browser crashes to Microsoft. Thus, closing as WORKSFORME.

comment:11 Changed 6 months ago by cypherpunks

Resolution: worksforme
Status: closedreopened

The problem in this bug is gone, though, as Windows users are not prompted anymore to send their Tor Browser crashes to Microsoft.

No. This is a configurable feature of Windows to send crash reports automatically or by prompt.

comment:12 in reply to:  11 Changed 6 months ago by gk

Resolution: duplicate
Status: reopenedclosed

Replying to cypherpunks:

The problem in this bug is gone, though, as Windows users are not prompted anymore to send their Tor Browser crashes to Microsoft.

No. This is a configurable feature of Windows to send crash reports automatically or by prompt.

I think I got prompted before but I don't do now anymore. But, really, the way to make progress here is #23624. So, let's dupe it over then if that sounds more reasonable to our cypherpunk.

comment:13 Changed 6 months ago by cypherpunks

Resolution: duplicate
Status: closedreopened

Only arma knows what is more reasonable, but this ticket seems to be about Windows Error Reporting, and #23624 seems to be not about Windows Expert Bundle.

comment:14 Changed 6 months ago by sjmurdoch

Cc: sjmurdoch removed

comment:15 in reply to:  13 Changed 6 months ago by gk

Resolution: duplicate
Status: reopenedclosed

Replying to cypherpunks:

Only arma knows what is more reasonable, but this ticket seems to be about Windows Error Reporting, and #23624 seems to be not about Windows Expert Bundle.

There was no Windows expert bundle then. Please let this ticket closed now and file a new one for Tor Core if you think that's smart or plainly move the component. This is not a thing for Tor Browser at least.

Last edited 6 months ago by gk (previous) (diff)

comment:16 Changed 6 months ago by cypherpunks

There was no Windows expert bundle then.

Wat? It was about "Is this issue specific to Tor-the-program, or should we be considering other bundle components too?"

if you think that's smart

Seems arma thought that was smart and, thus, filed this ticket.

plainly move the component

cypherpunks are not allowed to do that any more.

This is not a thing for Tor Browser at least.

Windows Expert Bundle is.

comment:17 Changed 6 months ago by gk

Component: Applications/Tor BrowserCore Tor/Tor
Keywords: needs-triage removed
Resolution: duplicate
Status: closedreopened

comment:18 Changed 6 months ago by teor

Keywords: windows added
Milestone: Tor: unspecified
Note: See TracTickets for help on using tickets.