Opened 8 years ago

Closed 8 years ago

#3904 closed defect (fixed)

TBB build package lacks patches

Reported by: tmpname0901 Owned by: erinn
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The build of the TBB (from tor-browser-2.2.32-2-src.tar.gz) fails with this error:

cp: cannot stat `../src/current-patches/000*': No such file or directory

That's because there actually isn't a directory named "current-patches" in the build tree. If the TBB maintainer prefers not to bundle the current patches with the build files, can we have them downloaded with the TBB component source tarballs?

That said, I'd like to make the case for including the patches with the build files. The patches are applied to a specific version of a given component source package (i.e. Firefox 6.0.1). It makes sense to me that patches associated with source version x should be kept with the build that specifies that version.

Child Tickets

Change History (5)

comment:1 Changed 8 years ago by mikeperry

Component: Tor BrowserTor bundles/installation
Owner: changed from mikeperry to erinn
Status: newassigned
Version: Tor: 0.2.2.32

comment:2 Changed 8 years ago by erinn

Status: assignedaccepted

Ah. That was an oversight. The srcdist target, which makes the tarball, has this:
cd $(SRCDEST); tar --exclude src/archived-patches --exclude src/current-patches --exclude src/processtest --exclude .git -czvf $(SRCNAME)-src.tar.gz $(SRCNAME)

I can take out the second one. I don't use either of the other two when building, so they can remain excluded.

comment:3 Changed 8 years ago by arma

Thanks for keeping us honest here! Making sure people can reproduce all the steps of building TBB is really valuable.

comment:4 Changed 8 years ago by mikeperry

tmpname0901: In particular, you might be interested in #3688. The ultimate goal is to be able to provide instructions and scripts for people to produce identical TBB binaries on two different machines, to provide a way to guard against build machine compromise. All of your tickets are helpful to eliminating the barriers towards getting to that goal. Thanks!

comment:5 Changed 8 years ago by erinn

Resolution: fixed
Status: acceptedclosed

I've fixed this bug as of 2.2.32-3. Closing. thanks for the report!

Note: See TracTickets for help on using tickets.