Vidalia torrc editor 'Save settings' checkbox is useless

Changes made using Vidalia's torrc editor are always saved to disk, even when the 'Save settings' checkbox is unchecked.

I doubt that Vidalia can change Tor's configuration without saving the changes in torrc soon afterward, so this checkbox should be removed.

added archived-closed-2018-07-04 component::archived/vidalia owner::chiiph priority::low resolution::wontfix severity::blocker status::closed type::defect version::vidalia 0.2.20 labels

Changes in torrc are applied via SETCONF control command. If the "Save settings" checkbox is check, it issues a SAVECONF control command.

So, does this happen the same if you issue a SETCONF control command by hand?

Replying to chiiph:

Changes in torrc are applied via SETCONF control command. If the "Save settings" checkbox is check, it issues a SAVECONF control command.

So, does this happen the same if you issue a SETCONF control command by hand?

No. But clicking 'OK' in Vidalia's 'Settings' dialog sends SAVECONF, and nearly all users will click 'OK' there after they finish using the 'Edit current torrc' dialog.

I agree with rransom.

A glance at the master branch's code (0.2.21) revealed that the application has not been designed to deal with a 'temporary setting' : SAVECONF is called in ServiceSettings.cpp, ConfigDialog.cpp and TorrcDialog.cpp. ConfigDialog should be the only one to handle the SAVECONF command otherwise the service editing & the torrc editing override each other - because it iterates through a stack to save the whole set of pages -, thus the undesired behaviours which occur when a SAVECONF is issued after a SETCONF.

Since the feature is not really essential and seems to have disappeared from branch alpha (0.3.3-alpha) I also suggest to remove the checkbox from the TorrcDialog.ui in the current branch master.

Trac:
Username: onizuka
Cc: N/A to onizuka.xxxx@gmail.com
Version: N/A to Vidalia: 0.2.20

I am very new to Tor Dev.

Would deleting the checkbox from TorrcDialog.ui (using Qt Creator GUI) be both sufficient & necessary or any other changes would be required in addition to that?

Trac:
Username: ashishnitinpatil

Trac:
Username: ashishnitinpatil
Cc: onizuka.xxxx@gmail.com to onizuka.xxxx@gmail.com, cool_asis_is@yahoo.in

Trac:
Username: ashishnitinpatil

TorrcDialog.diff

The patch file (for both .ui & .cpp combined)

Trac:
Username: ashishnitinpatil

1. Deleted the checkbox "chkSave" from TorrcDialog.ui
2. Deleted corresponding trigger "if(ui.chkSave->isChecked())" from TorrDialog.cpp

First patch from me, for Tor. Would love to make any more changes if required.

Trac:
Username: ashishnitinpatil
Status: new to needs_review

Sorry, got the action wrong.

Trac:
Username: ashishnitinpatil
Status: needs_review to needs_revision

My bad.

Trac:
Username: ashishnitinpatil
Status: needs_revision to needs_review

Trac:
Username: ashishnitinpatil
Cc: onizuka.xxxx@gmail.com, cool_asis_is@yahoo.in to onizuka.xxxx@gmail.com, cool_asis_is@yahoo.in, ashishnitinpatil@gmail.com

Trac:
Sponsor: N/A to N/A
Reviewer: N/A to N/A
Severity: N/A to Blocker
Keywords: easy deleted, N/A added

Close all tickets in archived components

Trac:
Resolution: N/A to wontfix
Keywords: N/A deleted, archived-closed-2018-07-04 added
Status: needs_review to closed

closed

mentioned in issue #8898 (closed)