Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#3951 closed enhancement (fixed)

Enable DirReqStatistics and ExtraInfoStatistics in 0.2.2.x?

Reported by: arma Owned by:
Priority: High Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: karsten Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

As part of #3338, we learned that about 20% of the relays by capacity are reporting directory request statistics.

When that fraction drops towards 10%, we get crazy spikes in our user statistics that ruin our graphs and make our users and funders confused.

Karsten suggested that getting the fraction of reporting capacity up to 33% or 50% would make the numbers more accurate and more stable.

Tor 0.2.3.x relays report the stats automatically. Tor 0.2.2.x relays only do it if you add two lines to your torrc:

DirReqStatistics 1
ExtraInfoStatistics 1

I was just looking over the torstatus pages and drafting mails to the fast relays that don't have dirreq lines in their extrainfo descriptors, when I realized that was a losing battle.

How about we just change the defaults in an upcoming 0.2.2.x stable release?

We've got plenty of cases of 0.2.2 relays running just fine with these config options. And if we don't change the defaults, I'm going to waste a bunch of time contacting all the stable relay operators and getting them to muck with their torrc manually. And if it turns out to be a bad idea to have it on, it might be even worse (for us and for the network) to contact them all again and try to get them each to manually back out.

Child Tickets

Change History (8)

comment:1 Changed 8 years ago by karsten

I think changing the default in 0.2.2.x should be fine.

How do we move this forward? Write a one-line patch and change the status to needs_review? :)

comment:2 Changed 8 years ago by arma

Yes. I expect the changes file will be more than one line though. :)

comment:3 Changed 8 years ago by arma

Priority: normalmajor

I'm hoping this will go into the next stable.

comment:4 Changed 8 years ago by karsten

Status: newneeds_review

See branch feature3951 in my public repository. This is the cherry-picked commit 49966152 from last November when we changed the default for 0.2.3.x. I briefly ran a relay running this branch, both with and without a GeoIP file, and it seemed to work fine.

comment:5 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

The changes file needed a small tweak: by policy, every change in maint-0.2.2 is supposed to reference a ticket number.

Merged.

comment:6 in reply to:  5 Changed 8 years ago by karsten

Replying to nickm:

The changes file needed a small tweak: by policy, every change in maint-0.2.2 is supposed to reference a ticket number.

Ah, I didn't know.

Merged.

Thanks!

comment:7 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:8 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.