Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#3953 closed defect (fixed)

micro-revision and source sha1sums do not work when not building in the source tree.

Reported by: weasel Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

configure allows you to build your binaries in a dedicated build tree instead of polluting the source tree with binary droppings.

i.e. mkdir build-tree && cd $_ && <pathtoconfigure>/configure && make

Tor's Makefiles create src/common/common_sha1.i, src/or/micro-revision.i and src/or/or_sha1.i from source files, however the makefiles do not handle the build-tree != source-tree case correctly.

Child Tickets

Attachments (2)

0001-Handle-build-trees-better.patch (2.6 KB) - added by nickm 9 years ago.
patch by weasel
0002-And-a-changes-file-for-bug3953.patch (706 bytes) - added by nickm 9 years ago.
second patch by weasel

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by nickm

patch by weasel

Changed 9 years ago by nickm

second patch by weasel

comment:2 Changed 9 years ago by nickm

Milestone: Tor: 0.2.3.x-final
Status: newneeds_review

comment:3 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks great. Merging (with a minor tweak to the changes file where I say it's a bugfix on 0.2.0.1-alpha.)

comment:4 Changed 8 years ago by nickm

Keywords: tor-client added

comment:5 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.