Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#4020 closed enhancement (fixed)

Tor doesn't log the public address it is warning about

Reported by: rransom Owned by: tomfitzhenry
Priority: Low Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Sep 14 04:11:29.519 [warn] You specified a public address for SocksPort. Other people on the Internet might find your computer and use it as an open proxy. Please don't allow this unless you have a good reason.

Tor 0.2.2.x printed the address it was complaining about. Tor 0.2.3.x doesn't, because the original string which the user specified in the config file is not available to the function which complains now.

Child Tickets

Attachments (2)

0001-Reinstate-address-in-warning-message-when-binding-no.patch (1.8 KB) - added by tomfitzhenry 8 years ago.
v2-0001-Reinstate-address-in-warning-message-when-binding-no.patch (1.7 KB) - added by tomfitzhenry 8 years ago.
Revised to use fmt_addr rather than tor_addr_to_str

Download all attachments as: .zip

Change History (13)

comment:1 Changed 9 years ago by nickm

Milestone: Tor: 0.2.3.x-final

comment:2 Changed 9 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: unspecified

comment:3 Changed 8 years ago by tomfitzhenry

Owner: set to tomfitzhenry
Status: newassigned

comment:4 Changed 8 years ago by rransom

Status: assignedneeds_review

Oooh! A patch!

comment:5 Changed 8 years ago by rransom

Status: needs_reviewneeds_revision

Use fmt_addr, not tor_addr_to_str.

Changed 8 years ago by tomfitzhenry

Revised to use fmt_addr rather than tor_addr_to_str

comment:6 Changed 8 years ago by tomfitzhenry

Status: needs_revisionneeds_review

comment:7 Changed 8 years ago by rransom

Looks good! Thanks!

comment:8 Changed 8 years ago by andrea

Was this ever merged? I'm trying to sort through some of the needs_review tickets, and it looks like this got reviewed months ago but the ticket was never resolved.

comment:9 Changed 8 years ago by nickm

Milestone: Tor: unspecifiedTor: 0.2.4.x-final
Resolution: fixed
Status: needs_reviewclosed

I don't think it was merged, no. I'm merging it onto master. Thanks, Tom!

comment:10 Changed 8 years ago by nickm

Keywords: tor-client added

comment:11 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.