Opened 8 years ago

Closed 8 years ago

#4092 closed enhancement (worksforme)

Arm should recognise similar Tor log entries and treat them as duplicates

Reported by: StrangeCharm Owned by: atagar
Priority: Low Milestone:
Component: Core Tor/Nyx Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Many of Tor's log entries are similar modulo the inclusion of a specific number. These entries should be treated like duplicates despite being different. Ideally, Arm's file of regular expressions for log entries should be updated with Tor.

Child Tickets

Change History (1)

comment:1 Changed 8 years ago by atagar

Resolution: worksforme
Status: newclosed

Hi, as we discussed via irc a few months back arm *does* do this. The log snippets that it uses for deduplication are the "msg.*" entries in src/settings.cfg. For examples...

251 # Snippets from common log messages
252 # These are static bits of log messages, used to determine when entries with
253 # dynamic content (hostnames, numbers, etc) are the same. If this matches the
254 # start of both messages then the entries are flagged as duplicates. If the
255 # entry begins with an asterisk (*) then it checks if the substrings exist
256 # anywhere in the messages.
304 msg.BW READ:
305 msg.DEBUG connection_handle_write(): After TLS write of
306 msg.DEBUG flush_chunk_tls(): flushed
307 msg.DEBUG conn_read_callback(): socket
308 msg.DEBUG conn_write_callback(): socket
... etc

This currently just includes the messages that bugged me. If there's log entries that you'd like to include then feel free to submit a patch (don't forget to include an example of the full message in the comment above).

Cheers! -Damian

Note: See TracTickets for help on using tickets.