Opened 8 years ago

Closed 8 years ago

#4174 closed defect (wontfix)

trivial_validate script does not work on OS X

Reported by: dtauerbach Owned by: pde
Priority: Low Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When trying to run makexpi.sh on my OS X machine, trivial_validate fails. Here is the output:

"""
bash-3.2$ ./makexpi.sh
-- Rules not anchored to beginning of a line:
(None.)

-- Rules with unescaped dots outside of brackets and left of a slash:
(None.)

-- Rules with backslashes in to pattern:
(None.)

-- Rules not containing trailing slash in from pattern:
(None.)

-- Rules not containing trailing slash in to pattern:
(None.)

-- Rules with missing closing slash in rule XML tag:
(None.)

-- Rules with multiple wildcards in a single target rule:
(None.)

-- Rules with targets containing URLs/paths instead of hostnames:
(None.)

-- Rules redirecting to http in to pattern:
(None.)

-- Rules containing space before to pattern:
(None.)

-- Rules with syntactically invalid regular expressions:
BYU.xml
HSBC.xml
University-of-North-Texas.xml

-- Rules with syntatically invalid XML:
(None.)

-- Rules containing non-ASCII characters (possible homoglyph attacks):
(None.)

--- Rules that lack at least one valid <target> tag:
(None.)

--- Duplicated ruleset names:
(None.)

--- Duplicated target hosts:
*.facebook.com
*.google.com
facebook.com
google.*
google.co.*
google.com
google.com.*
www.google.*
www.google.co.*
www.google.com
www.google.com.*
(not exiting)
ERROR: Validation of rulesets failed.
"""

I understand this works on Linux, and might relate to different bash semantics. It seems using trivial_validate.py would fix this problem.

Child Tickets

Change History (2)

comment:1 Changed 8 years ago by pde

Is this fixed now?

comment:2 Changed 8 years ago by dtauerbach

Resolution: wontfix
Status: newclosed

Fixed in the sense that makexpi.sh uses trivial_validate.py which does not have this problem. I'm marking as "won't fix"

Note: See TracTickets for help on using tickets.