Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#4196 closed defect (fixed)

Fix issues found by Coverity Scan in run 224 (22 Sep)

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


See branches cov_run244 for merge to master, and cov_run244_022 for merge to maint-0.2.2.

The remaining issues in run 224 seem harmless or false-positivish.

Child Tickets

Change History (7)

comment:1 Changed 9 years ago by nickm

Status: newneeds_review

comment:2 Changed 9 years ago by nickm

Merging cov_run224_022 after review by sebastian.

comment:3 Changed 9 years ago by nickm

Pushed a squash! patch to cov_run224 after review by sebastian.

comment:4 Changed 9 years ago by Sebastian

0b8c84b6c660ec06532e7b7708e461ef41a071b5 looks obviously correct. I think we can commit the branch, it won't make stuff worse. Maybe we should add an XXX to remind us of #4320, or maybe it is enough to have that ticket.

comment:5 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

squashed and merged to master. No XXX added; if a ticket is insufficient to remind us of itself, we need to spend more time reviewing open tickets. :)

comment:6 Changed 8 years ago by nickm

Keywords: tor-client added

comment:7 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.