Fix issues found by Coverity Scan in run 224 (22 Sep)

See branches cov_run244 for merge to master, and cov_run244_022 for merge to maint-0.2.2.

The remaining issues in run 224 seem harmless or false-positivish.

changed milestone to %Tor: 0.2.3.x-final

added component::core tor/tor milestone::Tor: 0.2.3.x-final priority::medium resolution::fixed status::closed tor-client type::defect labels

Trac:
Status: new to needs_review

Merging cov_run224_022 after review by sebastian.

Pushed a squash! patch to cov_run224 after review by sebastian.

0b8c84b6c660ec06532e7b7708e461ef41a071b5 looks obviously correct. I think we can commit the branch, it won't make stuff worse. Maybe we should add an XXX to remind us of #4320 (moved), or maybe it is enough to have that ticket.

squashed and merged to master. No XXX added; if a ticket is insufficient to remind us of itself, we need to spend more time reviewing open tickets. :)

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

Trac:
Keywords: N/A deleted, tor-client added

Trac:
Component: Tor Client to Tor

closed

mentioned in issue #4320 (moved)

moved to tpo/core/tor#4196 (closed)

mentioned in issue tpo/core/tor#4320 (closed)