Overzealous clock skew checking keeps clients from working
The check for time skew in connection_or.c which produces the log message: "Router '%s' (%s:%d) has a skewed clock..." seems to get called even when Tor is running as a client. This is not as intended; only servers should be forced to make sure their clocks are relatively correct.
Arma questions whether we should care about clock skew at all. The attacks that we're protecting against are server impersonation attacks where the attacker manage to compromise an older private key for a server, but not a newer one. This doesn't seem very realistic now, since compromising a server's private key will almost surely reveal its identity key; but a slightly cleverer key management system might in the future make this attack meaningfully difficult.
[Automatically added by flyspray2trac: Operating System: All]